cmake: update initialization#15101
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Aug 14, 2019
Merged
Conversation
hugolm84
reviewed
Jul 20, 2019
cmake/system/OpenCV_WinRT.cmake
Outdated
|
|
||
| # Making definitions available to other configurations and | ||
| # to filter dependency restrictions at compile time. | ||
| if(CMAKE_SYSTEM_NAME MATCHES WindowsPhone) |
Contributor
There was a problem hiding this comment.
In light of previous discussion (#15059 (comment)), this should be changed to use the WINDOWS_STORE and WINDOWS_PHONE variables instead. https://cmake.org/cmake/help/latest/variable/WINDOWS_STORE.html https://cmake.org/cmake/help/latest/variable/WINDOWS_PHONE.html
These are set to true if the CMAKE_SYSTEM_NAME matches the specific system and available after project()
Member
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.