Skip to content

G-API: Fluid Internal Parallelism#15091

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
anton-potapov:fluid_internal_parallellism_custom_pfor
Jul 24, 2019
Merged

G-API: Fluid Internal Parallelism#15091
opencv-pushbot merged 1 commit intoopencv:masterfrom
anton-potapov:fluid_internal_parallellism_custom_pfor

Conversation

@anton-potapov
Copy link
Copy Markdown
Contributor

@anton-potapov anton-potapov commented Jul 18, 2019 •
edited by alalek
Loading

This pullrequest adds:

  • ability to use custom implementation of "parallel for" function for Fluid internal parallelism
build_gapi_standalone:Linux x64=ade-0.1.1d
build_gapi_standalone:Win64=ade-0.1.1d
build_gapi_standalone:Mac=ade-0.1.1d
build_gapi_standalone:Linux x64 Debug=ade-0.1.1d

@anton-potapov
Copy link
Copy Markdown
Contributor Author

anton-potapov commented Jul 18, 2019

@rgarnov please welcome :)

@anton-potapov
Fluid Internal Parallelism
8936d55 
 - added ability to use custom implementation of "parallel for" function
@anton-potapov anton-potapov force-pushed the fluid_internal_parallellism_custom_pfor branch from d2010cd to 8936d55 Compare July 19, 2019 09:19
@anton-potapov
Copy link
Copy Markdown
Contributor Author

anton-potapov commented Jul 19, 2019 •
edited
Loading

@dmatveev please take a look, the patch is relatively small

dmatveev
dmatveev reviewed Jul 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach a performance diff to ensure there's no regressions

modules/gapi/include/opencv2/gapi/fluid/gfluidkernel.hpp

struct GFluidParallelFor
{
std::function<void(std::size_t, std::function<void(std::size_t)>)> parallel_for;
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a comment here what internal lambda argument (std::size_t is about)

modules/gapi/src/backends/fluid/gfluidbackend.cpp
for (std::size_t i = 0; i < count; ++i){
f(i);
}
};
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y not cv::parallel_for?

Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serial version could be used for standalone-build fallback

@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Jul 23, 2019

Filed a follow-up task to clean-up comments as @anton-potapov returns from vacation.

@alalek I think now it can be merged in this form

@dmatveev dmatveev self-assigned this Jul 23, 2019
dmatveev
dmatveev approved these changes Jul 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments, thanks

@opencv-pushbot opencv-pushbot merged commit 8936d55 into opencv:master Jul 24, 2019
opencv-pushbot pushed a commit that referenced this pull request Jul 24, 2019
@alalek
Merge pull request #15091 from anton-potapov:fluid_internal_parallell…
89f23a3 
…ism_custom_pfor
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Jul 25, 2019

Thanks!

@anton-potapov anton-potapov mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi feature

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@anton-potapov @dmatveev @opencv-pushbot @alalek