Merged
Conversation
alalek
reviewed
Jul 18, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
What is about testing of .dump() called twice?
modules/dnn/test/test_misc.cpp
Outdated
| TEST(dump, Regression) | ||
| { | ||
| Net net = readNet(findDataFile("dnn/squeezenet_v1.1.prototxt"), | ||
| findDataFile("dnn/squeezenet_v1.1.caffemodel")); |
Member
There was a problem hiding this comment.
.caffemodelfiles are not in opencv_extra. So this test data is considered optional.
See #15052
Member
There was a problem hiding this comment.
dnn/squeezenet_v1.1.prototxt is in opencv_extra. false is not needed there.
(issue is catched by OPENCV_TEST_CHECK_OPTIONAL_DATA=1)
modules/dnn/test/test_misc.cpp
Outdated
| Mat input = blobFromImage(imread(findDataFile("dnn/googlenet_0.png")), 1.0f, | ||
| Size(227,227), Scalar(), false, true); | ||
| net.setInput(input); | ||
| net.dump(); |
Member
There was a problem hiding this comment.
Test without check looks strange.
Lets check that result is not empty at least.
Merged
dvd42
pushed a commit
to dvd42/opencv
that referenced
this pull request
Aug 6, 2019
* Fix dumpToFile * Add test * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #15016