core(persistence): struct storage layout without alignment gaps#15050
Merged
opencv-pushbot merged 2 commits intoopencv:3.4from Jul 18, 2019
Merged
core(persistence): struct storage layout without alignment gaps#15050opencv-pushbot merged 2 commits intoopencv:3.4from
opencv-pushbot merged 2 commits intoopencv:3.4from
Conversation
- writeRaw(): support structs - readRaw(): 'len' is buffer limit in bytes (documentation is fixed)
This was referenced Jul 16, 2019
mshabunin
approved these changes
Jul 18, 2019
| ); | ||
| if (!skip_message) | ||
| { | ||
| CV_LOG_WARNING(NULL, "Binary converter: struct storage layout has been changed in OpenCV 3.4.7. Alignment gaps has been removed from the storage containers. " |
Contributor
There was a problem hiding this comment.
Can we use CV_LOG_DEBUG and avoid introduction of new environment configuration parameter?
Member
Author
There was a problem hiding this comment.
DEBUG messages are not compiled into release builds by default
| @param vec Pointer to the destination array. | ||
| @param len Number of elements to read. If it is greater than number of remaining elements then all | ||
| of them will be read. | ||
| @param len Number of bytes to read (buffer size limit). If it is greater than number of |
Contributor
There was a problem hiding this comment.
Suggested change
| @param len Number of bytes to read (buffer size limit). If it is greater than number of | |
| @param len Number of bytes to read (buffer size limit). If it is greater than size of |
| @param vec Pointer to the destination array. | ||
| @param maxCount Number of elements to read. If it is greater than number of remaining elements then | ||
| all of them will be read. | ||
| @param len Number of bytes to read (buffer size limit). If it is greater than number of |
Contributor
There was a problem hiding this comment.
Suggested change
| @param len Number of bytes to read (buffer size limit). If it is greater than number of | |
| @param len Number of bytes to read (buffer size limit). If it is greater than size of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with extra: opencv/opencv_extra#636
relates #14977
Align with OpenCV 4.x rewritten implementation.
Rework tests.