Reduce store gathering pressures - speeds thresholds by up to 20%#15048
Merged
alalek merged 2 commits intoopencv:3.4from Jul 16, 2019
ChipKerchner:reduceStoreGatheringThreshold
Merged
Reduce store gathering pressures - speeds thresholds by up to 20%#15048alalek merged 2 commits intoopencv:3.4from ChipKerchner:reduceStoreGatheringThreshold
alalek merged 2 commits intoopencv:3.4from
ChipKerchner:reduceStoreGatheringThreshold
Conversation
alalek
reviewed
Jul 15, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Well done!
Please take a look on comments below.
modules/imgproc/src/thresh.cpp
Outdated
| const int N = 256; | ||
| int i, j, h[N] = {0}; | ||
| #if CV_ENABLE_UNROLLED | ||
| int h2[3][N] = {0}; |
Member
There was a problem hiding this comment.
Could you please change name for this to h_unrolled?
int h_unrolled[3][N] = {};
(= {} initialization should make MacOSX builder happy)
Contributor
Author
|
How or when does code like this get put into master? |
Member
|
We have regular merges from 3.4 into master (weekly/bi-weekly). |
Merged
dvd42
pushed a commit
to dvd42/opencv
that referenced
this pull request
Aug 6, 2019
…gThreshold * Reduce store gathering pressures - speeds thresholds by up to 20% * Rename temporary histogram array and initialize so that MACOSX builder is happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce store gathering pressures - speeds thresholds by up to 20%.