Skip to content

Support compiliation for <=VS13#15037

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
hugolm84:noop-noexcept-for-vs13
Jul 16, 2019
Merged

Support compiliation for <=VS13#15037
opencv-pushbot merged 1 commit intoopencv:3.4from
hugolm84:noop-noexcept-for-vs13

Conversation

@hugolm84
Copy link
Copy Markdown
Contributor

This pullrequest changes

Checking CV_CXX11 is not enough for MSVC <=1800 as the compiler is not fully c++11 compliant. This will fix compilation error using VS13, where noexcept is not supported.

After change:
if CV_CXX11 is defined and the compiler is NOT MSVC1800 and below, CV_NOEXCEPT is defined as noexcept, else no-op

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 245c256 into opencv:3.4 Jul 16, 2019
@alalek alalek mentioned this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants