Support compiliation for <=VS13#15037
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jul 16, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Checking CV_CXX11 is not enough for MSVC <=1800 as the compiler is not fully c++11 compliant. This will fix compilation error using VS13, where
noexceptis not supported.After change:
if CV_CXX11 is defined and the compiler is NOT MSVC1800 and below,
CV_NOEXCEPTis defined asnoexcept, elseno-op