Skip to content

V4L2: Add V4L2_PIX_FMT_Y10 (10 bit grey) support#15001

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
antmicro:v4l2-y10-support
Jul 9, 2019
Merged

V4L2: Add V4L2_PIX_FMT_Y10 (10 bit grey) support#15001
opencv-pushbot merged 1 commit intoopencv:3.4from
antmicro:v4l2-y10-support

Conversation

@tgorochowik
Copy link
Copy Markdown
Contributor

This PR adds support for 10-bit grey format for the V4L2 interface.
This is useful for some MIPI cameras that only support that pixel format.

The conversion is implemented in a similar way as the 16b grey conversion - so the output image is using just 8b and everything is divided by 4.0 to drop the two least significant bits.

@alalek
Copy link
Copy Markdown
Member

alalek commented Jul 9, 2019

Thank you for the contribution!

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@tgorochowik tgorochowik changed the base branch from master to 3.4 July 9, 2019 12:36
@tgorochowik
Copy link
Copy Markdown
Contributor Author

@alalek Thank you for your reply!
Rebased, changed the PR base and re-tested.

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 4997a6b into opencv:3.4 Jul 9, 2019
@alalek alalek mentioned this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants