Fix blob detector insertion sort (issue #12244)#14954
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jul 2, 2019
Merged
Fix blob detector insertion sort (issue #12244)#14954opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
Member
|
Thank you for the contribution! As a "bugfix" this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #12244
This pullrequest changes
This PR addresses a small bug in the implementation of insertion sort inside the blob detector, as found in issue #12244.
Reproducible example
Here is a dumbed down version of the bug and its solution that you can run on e.g. cpp.sh (using doubles instead of circles but the idea is the same). The fix is simple really, the implementation of insertion sort is comparing the wrong variable in the while loop.