G-API: GAPI_TRANSFORM internal functionality rework#14952
Merged
alalek merged 2 commits intoopencv:masterfrom Jul 24, 2019
Merged
G-API: GAPI_TRANSFORM internal functionality rework#14952alalek merged 2 commits intoopencv:masterfrom
alalek merged 2 commits intoopencv:masterfrom
Conversation
Contributor
Author
|
@rgarnov please, review. Need to figure out what to do with tests |
Add a couple of new tests on GAPI_TRANSFORM
Contributor
Author
|
Thanks, @dmatveev ! |
rgarnov
requested changes
Jul 12, 2019
dmatveev
reviewed
Jul 15, 2019
| using F = std::function<GComputation()>; | ||
|
|
||
| std::string description; | ||
| F pattern; |
Contributor
There was a problem hiding this comment.
What is the reason to have this as a callback? Maybe store a cv::GComputation as-is instead?
Contributor
There was a problem hiding this comment.
Will close after Alexey returns from a leave.
Contributor
Author
There was a problem hiding this comment.
Since this function doesn't operate with GArgs anymore there is no reason to have it as a callback. Can be easily changed if needed, just let me know.
Contributor
|
@rgarnov can you please check if your comments have been addressed? |
rgarnov
approved these changes
Jul 23, 2019
Contributor
|
Thanks! |
dvd42
pushed a commit
to dvd42/opencv
that referenced
this pull request
Aug 6, 2019
…cro_rework G-API: GAPI_TRANSFORM internal functionality rework (opencv#14952) * Change internal pattern and substitute signatures and refactor tests * Enhance GArrayU with type-checker function Add a couple of new tests on GAPI_TRANSFORM
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…cro_rework G-API: GAPI_TRANSFORM internal functionality rework (opencv#14952) * Change internal pattern and substitute signatures and refactor tests * Enhance GArrayU with type-checker function Add a couple of new tests on GAPI_TRANSFORM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes internal functions signatures and changes some tests