Skip to content

Add clip to deploy.prototxt#14938

Merged
opencv-pushbot merged 2 commits intoopencv:3.4from
LaurentBerger:face_clip
Jul 30, 2019
Merged

Add clip to deploy.prototxt#14938
opencv-pushbot merged 2 commits intoopencv:3.4from
LaurentBerger:face_clip

Conversation

@LaurentBerger
Copy link
Copy Markdown
Contributor

@LaurentBerger LaurentBerger commented Jun 30, 2019

try to solve issue #14841
@dkurt

Merge with extra: opencv/opencv_extra#650

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r1:16.04
build_image:Custom Win=openvino-2019r2.0
build_image:Custom Mac=openvino-2019r2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

allow_multiple_commits=1

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jun 30, 2019

Please estimate an accuracy on FDDB and WIDER datasets using https://github.com/opencv/opencv/blob/master/modules/dnn/misc/face_detector_accuracy.py. We need to check if there is no regression.

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 9, 2019

Please estimate an accuracy on FDDB and WIDER datasets using https://github.com/opencv/opencv/blob/master/modules/dnn/misc/face_detector_accuracy.py. We need to check if there is no regression.

Theoretically, numerical accuracy should be improved due cropping of implicit edges to image because labels are also in the image space so IoU will be higher.

@LaurentBerger, do you mind to keep accuracy threshold unchanged? Anyway now an entire output blob is returned from Net::forward

@LaurentBerger
Copy link
Copy Markdown
Contributor Author

@dkurt sorry for the delay. I must finish opencv python book before august. I think that I will work on this PR in august

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 21, 2019

@LaurentBerger, sounds great! Feel free to ask us any question.

I can evaluate it by myself

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 27, 2019

@LaurentBerger, please apply this commit to your branch: dkurt@f16c7ee

@LaurentBerger
Copy link
Copy Markdown
Contributor Author

LaurentBerger commented Jul 27, 2019

I have never done that :

cd temp
git clone -b face_clip https://github.com/dkurt/opencv.git
cd opencv
git format-patch -1 f16c7ee
cd myopencv
git am < /f/lib/temp/opencv/0001-Fixes-for-OpenCV-face-detection-network.patch

is it good if I apply previous command?

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 27, 2019

@LaurentBerger, maybe try this:

git checkout face_clip

git remote add dkurt https://github.com/dkurt/opencv
git fetch dkurt face_clip
git cherry-pick f16c7ee848f9fbc2a104e6f9a4c242ceee080844

@LaurentBerger
Copy link
Copy Markdown
Contributor Author

I hope that's good!

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Jul 27, 2019

@LaurentBerger, that's perfect! Thank you!

Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Cool! That's really sensitive change which should improve users experience. Thanks!

@dkurt dkurt self-assigned this Jul 27, 2019
@LaurentBerger
Copy link
Copy Markdown
Contributor Author

Yes now there is no problem in my used video. with clip 1 and #15118

@opencv-pushbot opencv-pushbot merged commit 47c5ee5 into opencv:3.4 Jul 30, 2019
@alalek alalek mentioned this pull request Aug 5, 2019
@dkurt dkurt mentioned this pull request Mar 27, 2020
6 tasks
@LaurentBerger LaurentBerger deleted the face_clip branch February 2, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants