cmake: support rpath-link linker option#14929
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jul 2, 2019
Merged
Conversation
- builds with CMAKE_SKIP_RPATH=ON should properly find project .so files from <build>/lib directory - $ORIGIN doesn't work properly in cross-compilation mode
Member
Author
|
👍 |
Contributor
|
I don't think we need this fix:
My suggestion is to recommend users either set up environment correctly when they remove RPATH from binaries, either correctly set all required options during build ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details are below.
(
CMAKE_SKIP_RPATHis widely used in OpenCV's cross-compilation toolchains - perhaps to avoid overriding ofLD_LIBRARY_PATHsettings)Build produces
libtbb.soin<build>/lib,libopencv_core.soin<build>/lib.But build may fail linking of apps/tests (
opencv_version) with message:or even worse, it may grab libtbb.so from the system with wrong version (
-Wl,--verboseoutput):(Launch with
LD_LIBRARY_PATHselectslibtbb.sofrom<build>/lib)Fix adds this linker parameter
-Wl,-rpath-link,"\$ORIGIN"and linker is able to find the proper version of libtbb.soOther system .so files are searched in this way:
Done:
$ORIGINmay not work (with cross-compilation?)Alternatives:
CMAKE_BUILD_RPATH_USE_ORIGINoption