[#14873] Fix code signing issue on Xcode 11 in Try Compile script#14875
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jun 25, 2019
Legoless:master
Merged
[#14873] Fix code signing issue on Xcode 11 in Try Compile script#14875opencv-pushbot merged 1 commit intoopencv:3.4from Legoless:master
opencv-pushbot merged 1 commit intoopencv:3.4from
Legoless:master
Conversation
Member
|
Thank you! Our builds are green too. This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
Contributor
Author
|
@alalek I did what you asked, I would think cherrypicking the commit into 3.4 would be the easier way, but there you go. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #14873.
This Pull Request Changes
The PR adds to the Try Compile script explicit flags not to use code signing, as by default Xcode 11 is now looking for signing identity and the entire script fails in this case.