Skip to content

dnn tensorflow support mirrorpad#14845

Merged
alalek merged 5 commits intoopencv:3.4from
vonchenplus:ocv_mirrorpad
Jun 24, 2019
Merged

dnn tensorflow support mirrorpad#14845
alalek merged 5 commits intoopencv:3.4from
vonchenplus:ocv_mirrorpad

Conversation

@vonchenplus
Copy link
Copy Markdown
Contributor

@vonchenplus vonchenplus commented Jun 20, 2019 •
edited by dkurt
Loading

Merge with extra: opencv/opencv_extra#622

dnn tensorflow support mirrorpad

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r1:16.04
build_image:Custom Win=openvino-2019r1
build_image:Custom Mac=openvino-2019r1

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

@vonchenplus vonchenplus changed the title Ocv mirrorpad dnn tensorflow support mirrorpad Jun 20, 2019
@vonchenplus vonchenplus mentioned this pull request Jun 20, 2019
Closed
@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 20, 2019

New features requires tests.
You can refer on adding tests for similar cases: #14315 (+testdata opencv/opencv_extra#595)

alalek
alalek reviewed Jun 20, 2019
View reviewed changes
dkurt
dkurt reviewed Jun 20, 2019
View reviewed changes
dkurt
dkurt reviewed Jun 21, 2019
View reviewed changes
@dkurt dkurt removed the pr: needs test New functionality requires minimal tests set label Jun 22, 2019
@dkurt dkurt self-assigned this Jun 22, 2019
dkurt
dkurt approved these changes Jun 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@alalek, Is that OK for opencv/opencv_extra#622 to have "merge 3.4" commit?

@alalek alalek merged commit 5620306 into opencv:3.4 Jun 24, 2019
@alalek alalek mentioned this pull request Jun 26, 2019
Merged
arnaudbrejeon pushed a commit to arnaudbrejeon/opencv that referenced this pull request Jan 23, 2020
@vonchenplus @arnaudbrejeon
Merge pull request opencv#14845 from vonchenplus:ocv_mirrorpad
f3df429 
* tensorflow support mirror pad

* revert macro define

* revert macro define

* reduce code duplication

* revert macro define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn feature

Projects

None yet

Milestone

3.4.7

Development

Successfully merging this pull request may close these issues.

3 participants

@vonchenplus @alalek @dkurt