Skip to content

Fix Python code to get the same result between the Cpp, Java and Python.#14837

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
Cartucho:fix_laplace_operator_on_python
Jul 1, 2019
Merged

Fix Python code to get the same result between the Cpp, Java and Python.#14837
opencv-pushbot merged 1 commit intoopencv:3.4from
Cartucho:fix_laplace_operator_on_python

Conversation

@Cartucho
Copy link
Copy Markdown
Contributor

This pullrequest changes

According to this stackoverflow question/answer, we need to add the flag ksize= to get the same result between C++, Java and Python.

This will fix the snippet code associted with the following tutorial file:
/opencv/doc/tutorials/imgproc/imgtrans/laplace_operator/laplace_operator.markdown

@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 19, 2019

Thank you for the contribution!

As a "bugfix" this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@Cartucho Cartucho changed the base branch from master to 3.4 June 23, 2019 16:59
@Cartucho Cartucho force-pushed the fix_laplace_operator_on_python branch from 86eec99 to e8283f9 Compare June 23, 2019 17:04
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit e8283f9 into opencv:3.4 Jul 1, 2019
@alalek alalek mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants