Skip to content

Trying clean install layout#14786

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
mshabunin:try-install-layout
Aug 28, 2019
Merged

Trying clean install layout#14786
opencv-pushbot merged 1 commit intoopencv:masterfrom
mshabunin:try-install-layout

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Jun 11, 2019

This pullrequest changes

  • extracted all OPENCV_*_INSTALL_PATH options from root CMakeLists.txt to separate file
  • OPENCV_SAMPLES_BIN_INSTALL_PATH for Unix is set to bin by default (was samples) - this variable is not used anywhere yet

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to create similar patch for 3.4 branch too.

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@opencv-pushbot opencv-pushbot merged commit 4e67eb6 into opencv:master Aug 28, 2019
@mshabunin mshabunin deleted the try-install-layout branch September 4, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build/install port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants