fix the bug, when k[4] is negative, icdist may be negative at the edg…#14583
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jun 14, 2019
FanaticsKang:fix_undistortPoint_bug
Merged
fix the bug, when k[4] is negative, icdist may be negative at the edg…#14583opencv-pushbot merged 1 commit intoopencv:3.4from FanaticsKang:fix_undistortPoint_bug
opencv-pushbot merged 1 commit intoopencv:3.4from
FanaticsKang:fix_undistortPoint_bug
Conversation
Member
|
Please capture your inputs and add some simple regression test for that case. |
kangzixiang
approved these changes
Jun 13, 2019
Member
|
@SachieKang Could you share some image/calibration parameters for regression test? |
Contributor
Author
|
I update a test, and #14800 is the test with original code. You will see the error by running ./bin/opencv_test_imgproc. |
alalek
approved these changes
Jun 14, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Looks good to me 👍
@FanaticsKang Please don't close #14800. It will be merged next.
opencv-pushbot
pushed a commit
that referenced
this pull request
Jun 14, 2019
Merged
arnaudbrejeon
pushed a commit
to arnaudbrejeon/opencv
that referenced
this pull request
Jan 23, 2020
…test Test request by opencv#14583 (opencv#14800) * add test to show the undistort bug * move test to calib3d
akretz
added a commit
to akretz/opencv
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes
The
cvUndistortPointsInternalfunction.The k[4] is negative of my camera, the
icdistwill be negative at the edge of image. This cause the error like the point at right will be undistort to the left.So the function will return when
icdist< 0, and use the last compute result.