videoio: added bad parameters handling to VideoWriter#14156
Merged
alalek merged 7 commits intoopencv:masterfrom Mar 29, 2019
Merged
videoio: added bad parameters handling to VideoWriter#14156alalek merged 7 commits intoopencv:masterfrom
alalek merged 7 commits intoopencv:masterfrom
Conversation
Member
|
We definitely should ban all "assert()" calls in OpenCV code, including tests. |
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
* videoio: added bad parameters handling to VideoWriter * AVFoundation/Writer: support UTF-8, check input parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
We expect no throw behavior for incorrect VideoWriter parameters, added test to check this.
Changes in GStreamer backend:
abort()calls with error handlingChanges in AVFoundation VideoWriter backend:
mov, qt, mp4, m4v, supported FourCC codes:JPEG, MJPEG, jpeg, mjpeg, H264, avc1)Changes in MediaSDK backend:
fpscheck and modified