Fixed warnings produced by clang-9.0.0#13705
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Feb 1, 2019
Merged
Conversation
e61faa0 to
3bdfeea
Compare
3bdfeea to
ea3dc78
Compare
alalek
reviewed
Feb 1, 2019
| struct tuple_wrap_helper<std::tuple<Objs...>> | ||
| { | ||
| static std::tuple<Objs...> get(std::tuple<Objs...>&& objs) { return objs; } | ||
| static std::tuple<Objs...> get(std::tuple<Objs...>&& objs) { return std::forward<std::tuple<Objs...>>(objs); } |
Contributor
There was a problem hiding this comment.
Basically I am ok with this (tests pass means it works)
dmatveev
approved these changes
Feb 1, 2019
| struct tuple_wrap_helper<std::tuple<Objs...>> | ||
| { | ||
| static std::tuple<Objs...> get(std::tuple<Objs...>&& objs) { return objs; } | ||
| static std::tuple<Objs...> get(std::tuple<Objs...>&& objs) { return std::forward<std::tuple<Objs...>>(objs); } |
Contributor
There was a problem hiding this comment.
Basically I am ok with this (tests pass means it works)
opencv-pushbot
pushed a commit
that referenced
this pull request
Feb 1, 2019
This was referenced Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with opencv/opencv_contrib#1980
This pullrequest changes
warning: declaration shadows a static data member of 'cv::FileStorage' [-Wshadow]warning: local variable xxxxx will be copied despite being returned by name [-Wreturn-std-move]warning: explicitly assigning value of variable of type 'Ptr<opencv_test::(anonymous namespace)::anonymous namespace)::Reporter>' to itself [-Wself-assign-overloaded]