Framework for dynamic videoio backends, FFmpeg and GStreamer plugins#13677
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Feb 26, 2019
Merged
Framework for dynamic videoio backends, FFmpeg and GStreamer plugins#13677opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
bc2bb34 to
2962a57
Compare
219e83d to
4447253
Compare
alalek
reviewed
Feb 4, 2019
| { | ||
| Read, | ||
| Write, | ||
| ReadWrite |
| } | ||
| catch (...) | ||
| { | ||
| } |
Member
There was a problem hiding this comment.
Some logging message would be useful here.
and below for "catch (...)"
| { | ||
| CV_LOG_INFO(NULL, "VIDEOIO: Disable backend: " << info.name); | ||
| const int env_priority2 = static_cast<int>(backendOrder.end() - backendPos - 1); | ||
| be.priority = 10000 + 1000 * env_priority2; |
Member
There was a problem hiding this comment.
Was:
info.priority = (int)(100000 + (names.size() - i) * 1000);
Most part of changes here doesn't look necessary to add plugin support.
| { | ||
| info.priority = (int)param_priority; | ||
| enabled++; | ||
| Ptr<DynamicBackend> plugin = DynamicBackend::load(be.id, (int)be.mode); |
Member
There was a problem hiding this comment.
We should not load plugins here.
Lets just assign priorities (keep old code).
At least, there is no way to bypass plugin loading via OPENCV_VIDEOIO_PRIORITY_XXX=0.
4447253 to
9c4fb65
Compare
e935346 to
9702987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Added ability to build plugins for videoio module. Implemented for two most popular backends: FFmpeg and GStreamer.
./opencv/modules/videoio/misc/build_plugins.sh <path-to-dst-dir> <cmake-build-config>OPENCV_VIDEOIO_PLUGIN_PATH- list of directories to search for plugins (default is location of libopencv_videoio.so)OPENCV_VIDEOIO_PLUGIN_NAME- glob expression to match plugin binaries (default islibopencv_videoio_*.so)Public interfaces
Tests
videoio_xxx.yyyOther changes