Merged
Conversation
| log.info("=====") | ||
|
|
||
| os.chdir(engdest) | ||
| builder.build_engine(abi, engdest) |
| @@ -303,7 +236,6 @@ def gather_results(self, engines): | |||
| parser.add_argument('--sign_with', help="Certificate to sign the Manager apk") | |||
There was a problem hiding this comment.
Could you change
parser.add_argument('--config', default='ndk-10.config.py',
to?
parser.add_argument('--config', default='ndk-17.config.py',
| @@ -303,7 +236,6 @@ def gather_results(self, engines): | |||
| parser.add_argument('--sign_with', help="Certificate to sign the Manager apk") | |||
| parser.add_argument('--build_doc', action="store_true", help="Build javadoc") | |||
| parser.add_argument('--no_ccache', action="store_true", help="Do not use ccache during library build") | |||
There was a problem hiding this comment.
Could you disable ccache by default? (maybe change no_ccache to enable_ccache)
ccache in not available by default on Linux
ccache is not available on Windows
|
Member
Author
|
You can try Android package with this PR (see description above for the link) |
https://github.com/gradle/gradle/tree/v4.6.0 License: Apache 2.0
- drop hello-android sample
Member
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #8460
Usage (build Android package):
Android package for testing is here.
TODO:
test_gradle=1property)