Merged
Conversation
alalek
reviewed
Nov 23, 2018
modules/imgproc/src/filter.cpp
Outdated
| Mat src = (src_step != dst_step) ? Mat(Size(width, height), stype, src_data, src_step) : Mat(Size(full_width-offset_x, full_height-offset_y), stype, src_data, src_step); | ||
| Mat dst = (src_step != dst_step) ? Mat(Size(width, height), dtype, dst_data, dst_step) : Mat(Size(full_width, full_height), dtype, dst_data, dst_step); | ||
| int _width = (src_step != dst_step) ? width : full_width; | ||
| int _height = (src_step != dst_step) ? height : full_height; |
Member
There was a problem hiding this comment.
(src_step != dst_step)
I believe this condition should be improved (steps have no correlation with image sizes / ROIs).
alalek
reviewed
Nov 23, 2018
Contributor
|
ok, this looks good as a temporary solution; however, it looks like it solves the problem by disabling DFT-based convolution in some cases, which may result in significant speed degradation when we use ROI of the source image (e.g. we took 10000x10000 image and took 9990x9990 ROI of it to filter using 11x11 kernel - that would be very very slow). Nevertheless, let's merge it and wait for the subsequent, more efficient fixes 👍 |
b498746 to
864e3c3
Compare
864e3c3 to
e0b664f
Compare
Contributor
Author
|
@vpisarev Many thanks for your follow-up. I resolved the merge conflict. I will work on improving this problem in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #13179