G-API: update tests checks#13096
Merged
opencv-pushbot merged 2 commits intoopencv:masterfrom Nov 14, 2018
Merged
Conversation
Contributor
ghost
reviewed
Nov 13, 2018
|
In general, looks great! I haven't check tolerance values sanity for all tests, but redesign and functions renaming are very reasonable. |
ghost
reviewed
Nov 13, 2018
ghost
left a comment
There was a problem hiding this comment.
And as I can see, CI testing failed on Linux AVX2:
https://pullrequest.opencv.org/buildbot/builders/precommit_linux64-avx2/builds/151
This was referenced Nov 13, 2018
avoid `countNonZero()`, use `norm()`
Member
Author
Contributor
|
I have done reviewing this PR. It looks OK for merging for me. |
ghost
approved these changes
Nov 14, 2018
Contributor
|
@alalek thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.