V4L (V4L2): Refactoring. Added missed camera properties. Fixed getting `INF` for some properties. Singlethread as always by aleksey-nikolaev · Pull Request #12893 · opencv/opencv

aleksey-nikolaev · 2018-10-22T15:16:24Z

I made this changes because when I tried to get the exposure property I got the INF. Also, all values for my cam on windows are not same on linux.

This pullrequest changes

Added backward compatibility mode:
- Conversion parameters to/from [0,1] range with backward compatibility mode.
- Initial mode set by the environment variable OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED.
- Turn off backward compatibility mode by cv::CAP_PROP_MODE = 1 (enable normalized properties).
- Revert backward compatibility mode by cv::CAP_PROP_MODE = 0.
Added all known conversion from V4L2_CID_* to cv::CAP_PROP_*
Added new property cv::CAP_PROP_CHANNEL for all captures for selecting video input channel. Default value -1 - the channels not changed.
Fixed use of video buffer index.
Removed extra memcopy for grab image.
Removed open / close device when changing capture settings.
Removed write permission on the device mapped memory and attempts to write to this area.
Added conversion to RGB from formats: NV12, NV21, Y8

Some code refactoring:

Removed device closing from autosetup_capture_mode_v4l2
Refactoring of Convert To RGB, Set/Get of properties, frame capture initialization.
Added cap_properties verbalization.
Removed extra code, like querying or enumerating all device parameters or an extra {}.
Removed extra wrappers over cvtColor

I tried to keep the code format unchanged. It will be nice to have .clang-format on the OpenCV project.

1 Added cap_properties verbalization. 2 Set Get of properties elementary refactoring. 3 Removed converting parameters to/from [0,1] range. 4 Added all known conversion from V4L2_CID_* to CV_CAP_PROP_*

1. Removed all query for parameters range. 2. Refactored capture initialization. 3. Added selecting input channel by CV_CAP_PROP_MODE. Default value -1 the channels not changed.

1. Refactoring of Convert To RGB

1. Fixed use of video buffer index. 2. Removed extra memcopy for grab image. 3. Removed device closing from autosetup_capture_mode_v4l2

1. The `goto` was eliminated 2. Fixed use of temporary buffer index for V4L2_PIX_FMT_SN9C10X 3. Fixed use of the bufferIndex 4. Removed trailing spaces and unused variables.

1. Alias for capture->buffers[capture->bufferIndex] 2. Reduced size of data for memcpy: bytesused instead of length 3. Refactoring. Code duplication. More info for debug

modules/videoio/src/cap_v4l.cpp

1. Added the ability to grab and retrieveFrame independently several times

1. Not need to close/open device for new capture parameters applying. 2. Removed using of device name as a flag that the capture is closed. Added sufficient function. 3. Refactoring. Added requestBuffers and createBuffers

1. Added tryIoctl with `select` like was in mainloop_v4l2. 2. Fixed buffer request for device without closing the device. 3. Some static function moved to CvCaptureCAM_V4L 4. Removed unused defines

1. Thread-safe now

1. Fixed thread-safe destructor 2. Fixed FPS setting

modules/videoio/src/cap_v4l.cpp

aleksey-nikolaev · 2018-10-29T18:41:35Z

Unfortunately, I need this on 3.4. The main problem is a backward compatibility: [0,1] ranges for parameters. I could revert the ranges conversion and add the capture mode or a build option for using real parameters instead of converted. Would that be an acceptable compromise?

1. Reverted conversion parameters to/from [0,1] by default for backward compatibility. 2. Added setting for turn off compatibility mode: set CV_CAP_PROP_MODE to 65536 3. Most static functions moved to CvCaptureCAM_V4L 4. Refactoring of icvRetrieveFrameCAM_V4L and using of frame_allocated flag

aleksey-nikolaev · 2018-10-31T13:30:23Z

@alalek , @paroj , I've already deleted the mutex and returned the parameter ranges, is that enough or am I missing something?

1. Added conversion to RGB from NV12, NV21 2. Refactoring. Removed wrappers for known format conversions.

modules/videoio/src/cap_v4l.cpp

CAP_V4L migrated to use VideoCaptureProperties.

modules/videoio/src/cap_v4l.cpp

alalek · 2018-11-06T15:34:04Z

modules/videoio/src/cap_v4l.cpp

+    // any other value greater than 32768 revert backward compatibility mode.
+    // Backward compatibility mode affects the following parameters:
+    // cv::CAP_PROP_*: BRIGHTNESS,CONTRAST,SATURATION,HUE,GAIN,EXPOSURE,FOCUS,AUTOFOCUS,AUTO_EXPOSURE.
+    bool compatibilityMode;


Comment is outdated.
CAP_PROP_MODE is already used, so behavior should not be changed.

Alternative variant via environment variables:

compatibilityMode = !utils::getConfigurationParameterBool("OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED", false);

CAP_PROP_MODE was used for get - not for set

2. Environment variable `OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED` for setting default backward compatibility mode. 3. Revert getting of `CAP_PROP_MODE` as fourcc code in backward compatibility mode.

paroj · 2018-11-08T00:11:02Z

modules/videoio/src/cap_v4l.cpp

    deviceName = _deviceName;
    returnFrame = true;
-    compatibilityMode = utils::getConfigurationParameterBool("OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED", true);
+    compatibilityMode = !utils::getConfigurationParameterBool("OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED", false);


this was correct before:

compatibilityMode <=> "converted to/from [0,1) range" <=> OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED <=> 1

maybe either rename either compatibilityMode or OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED to match each other.

Thanks!
Renamed to normalizePropRange.

My bad, need to fix this again.

Done

aleksey-nikolaev · 2018-11-08T08:40:51Z

modules/videoio/src/cap_v4l.cpp

+
+    buffer() : start(NULL), length(0)
+    {
+        memset(&v4l2_buf, 0, sizeof(v4l2_buf));


v4l2_buf = v4l2_buffer() this initialization style is used in this cpp file. Please, don't mix it.

If you care about variable names, I could bring everything in this file to a single style, including renaming ambiguous entities

Renamed type instead.
Using v4l2_buffer() initializer.

`v4l2-ctl --list-formats` should have 'MJPG' entry

to avoid "munmap: Invalid argument" messages

alalek · 2018-11-08T16:38:46Z

@paroj @aleksey-nikolaev I believe it should be fine now. Any comments?

aleksey-nikolaev · 2018-11-08T17:03:10Z

code style maybe. And what about the comments at the top of the file, they're no longer relevant, are they?

alalek

Thank you!

washley · 2018-11-29T20:19:56Z

I think this broke builds on kernels < 3.5 (at least that, maybe an even higher version is required). See #13335

The format of destination is BGR24. However, when it was NV[12|21], it was set to RGB24. Fixes: Commit 8396ae6 ("Merge pull request opencv#12893 from aleksey-nikolaev:cap-update")

opencv-alalek · 2024-08-23T07:42:44Z

modules/videoio/src/cap_v4l.cpp

+        return;
+    case V4L2_PIX_FMT_NV12:
+        cv::cvtColor(cv::Mat(imageSize.height * 3 / 2, imageSize.width, CV_8U, currentBuffer.start), destination,
+                     COLOR_YUV2RGB_NV12);


COLOR_YUV2RGB_NV12

Bug is introduced here. Should be BGR by default.

Fixed here: #26081

Aleksey Nikolaev added 5 commits October 22, 2018 17:32

cap_v4l:

0c718a2

1 Added cap_properties verbalization. 2 Set Get of properties elementary refactoring. 3 Removed converting parameters to/from [0,1] range. 4 Added all known conversion from V4L2_CID_* to CV_CAP_PROP_*

cap_v4l:

2b00072

1. Removed all query for parameters range. 2. Refactored capture initialization. 3. Added selecting input channel by CV_CAP_PROP_MODE. Default value -1 the channels not changed.

cap_v4l:

4bef9c1

1. Refactoring of Convert To RGB

cap_v4l:

2d7ae91

1. Fixed use of video buffer index. 2. Removed extra memcopy for grab image. 3. Removed device closing from autosetup_capture_mode_v4l2

cap_v4l:

db7a100

1. The `goto` was eliminated 2. Fixed use of temporary buffer index for V4L2_PIX_FMT_SN9C10X 3. Fixed use of the bufferIndex 4. Removed trailing spaces and unused variables.

aleksey-nikolaev changed the title ~~V4L-2: Added camera properties mostly the same as on MSMF.~~ V4L (V4L2): Refactoring. Added missed camera properties. Fixed getting INF for some properties Oct 24, 2018

cap_v4l:

360c3f8

1. Alias for capture->buffers[capture->bufferIndex] 2. Reduced size of data for memcpy: bytesused instead of length 3. Refactoring. Code duplication. More info for debug

alalek reviewed Oct 24, 2018

View reviewed changes

modules/videoio/src/cap_v4l.cpp Outdated Show resolved Hide resolved

modules/videoio/src/cap_v4l.cpp Show resolved Hide resolved

Aleksey Nikolaev added 4 commits October 25, 2018 14:37

cap_v4l:

5a7e518

1. Added the ability to grab and retrieveFrame independently several times

cap_v4l:

c1178ca

1. Not need to close/open device for new capture parameters applying. 2. Removed using of device name as a flag that the capture is closed. Added sufficient function. 3. Refactoring. Added requestBuffers and createBuffers

cap_v4l:

5231910

1. Added tryIoctl with `select` like was in mainloop_v4l2. 2. Fixed buffer request for device without closing the device. 3. Some static function moved to CvCaptureCAM_V4L 4. Removed unused defines

cap_v4l:

6bf9106

1. Thread-safe now

aleksey-nikolaev changed the title ~~V4L (V4L2): Refactoring. Added missed camera properties. Fixed getting INF for some properties~~ V4L (V4L2): Refactoring. Added missed camera properties. Fixed getting INF for some properties. Thread-safe Oct 26, 2018

Aleksey Nikolaev added 2 commits October 26, 2018 17:20

cap_v4l:

c72fe6f

1. Fixed thread-safe destructor 2. Fixed FPS setting

Missed brake

bff5d57

alalek mentioned this pull request Oct 26, 2018

videoio: add manual white-balance and implement it for V4L2 #12962

Merged

paroj reviewed Oct 26, 2018

View reviewed changes

modules/videoio/src/cap_v4l.cpp Outdated Show resolved Hide resolved

paroj reviewed Oct 26, 2018

View reviewed changes

modules/videoio/src/cap_v4l.cpp Show resolved Hide resolved

alalek reviewed Oct 29, 2018

View reviewed changes

modules/videoio/src/cap_v4l.cpp Show resolved Hide resolved

modules/videoio/src/cap_v4l.cpp Outdated Show resolved Hide resolved

aleksey-nikolaev changed the base branch from 3.4 to master October 29, 2018 15:54

aleksey-nikolaev changed the title ~~V4L (V4L2): Refactoring. Added missed camera properties. Fixed getting INF for some properties. Thread-safe~~ V4L (V4L2): Refactoring. Added missed camera properties. Fixed getting INF for some properties. Singlethread as always Oct 29, 2018

Removed thread-safety

8303a27

aleksey-nikolaev changed the base branch from master to 3.4 October 29, 2018 18:50

aleksey-nikolaev changed the base branch from 3.4 to master October 29, 2018 18:51

aleksey-nikolaev force-pushed the cap-update branch from 8930bcd to 8303a27 Compare October 29, 2018 19:29

aleksey-nikolaev changed the base branch from master to 3.4 October 29, 2018 19:30

cap_v4l:

bec643f

1. Added conversion to RGB from NV12, NV21 2. Refactoring. Removed wrappers for known format conversions.

alalek reviewed Nov 1, 2018

View reviewed changes

modules/videoio/src/cap_v4l.cpp Outdated Show resolved Hide resolved

Added CAP_PROP_CHANNEL to the enum VideoCaptureProperties.

2f2d986

CAP_V4L migrated to use VideoCaptureProperties.

alalek reviewed Nov 6, 2018

View reviewed changes

1. Update comments.

232820b

2. Environment variable `OPENCV_VIDEOIO_V4L_RANGE_NORMALIZED` for setting default backward compatibility mode. 3. Revert getting of `CAP_PROP_MODE` as fourcc code in backward compatibility mode.

paroj reviewed Nov 8, 2018

View reviewed changes

aleksey-nikolaev commented Nov 8, 2018

View reviewed changes

alalek added 3 commits November 8, 2018 14:33

videoio: update cap_v4l - compatibilityMode => normalizePropRange

148f2d8

videoio(test): V4L2 MJPEG test

9095291

`v4l2-ctl --list-formats` should have 'MJPG' entry

videoio: fix buffer initialization

2346f41

to avoid "munmap: Invalid argument" messages

paroj approved these changes Nov 8, 2018

View reviewed changes

alalek approved these changes Nov 8, 2018

View reviewed changes

alalek merged commit 8396ae6 into opencv:3.4 Nov 8, 2018

This was referenced Nov 10, 2018

Merge 3.4 #13106

Merged

videoio(v4l): turn off normalization of V4L properties #13137

Merged

videoio: drop VideoCaptureModes enum in favour of fourcc #13151

Merged

washley mentioned this pull request Nov 29, 2018

Opencv 3.4.4 dependency on V4L2_CID_ISO_SENSITIVITY only available in kernel >= 3.5 #13335

Closed

alalek mentioned this pull request Dec 8, 2018

RGB frames for video files with Alpha channel support #13394

Open

alalek mentioned this pull request Jun 27, 2022

V4l2 multi planar #22165

Closed

6 tasks

opencv-alalek reviewed Aug 23, 2024

View reviewed changes

Uh oh!

Conversation

aleksey-nikolaev commented Oct 22, 2018 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This pullrequest changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aleksey-nikolaev commented Oct 29, 2018

Uh oh!

aleksey-nikolaev commented Oct 31, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek Nov 6, 2018

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Nov 7, 2018

Choose a reason for hiding this comment

Uh oh!

paroj Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek Nov 8, 2018

Choose a reason for hiding this comment

Uh oh!

alalek Nov 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Nov 8, 2018

Choose a reason for hiding this comment

Uh oh!

aleksey-nikolaev Nov 8, 2018

Choose a reason for hiding this comment

Uh oh!

alalek Nov 8, 2018

Choose a reason for hiding this comment

Uh oh!

alalek commented Nov 8, 2018

Uh oh!

aleksey-nikolaev commented Nov 8, 2018

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

washley commented Nov 29, 2018

Uh oh!

opencv-alalek Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aleksey-nikolaev commented Oct 22, 2018 •

edited by alalek

Loading

paroj Nov 8, 2018 •

edited

Loading

alalek Nov 8, 2018 •

edited

Loading

opencv-alalek Aug 23, 2024 •

edited

Loading