Skip to content

Add tests for features2d JavaScript bindings#12855

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:js_features2d_tests
Feb 2, 2019
Merged

Add tests for features2d JavaScript bindings#12855
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:js_features2d_tests

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Oct 16, 2018 •
edited
Loading

This pullrequest changes

resolves #12706

  • DMatch definition
  • tests
docker_image:Docs=docs-js
docker_image:Custom=javascript
buildworker:Docs=linux-1
buildworker:Custom=linux-1

@dkurt dkurt force-pushed the js_features2d_tests branch 2 times, most recently from ddc04b8 to 683a5d3 Compare October 16, 2018 10:48
@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Oct 18, 2018

The test numbers are received from python bindings:

import cv2 as cv
import numpy as np

image = np.zeros([100, 100], np.uint8)

cv.setRNGSeed(324)
cv.randu(image, 0, 255)

orb = cv.ORB_create()
kp = orb.detect(image)
print(len(kp))

mser = cv.MSER_create()
kp = mser.detect(image)
print(len(kp))

brisk = cv.BRISK_create()
kp = brisk.detect(image)
print(len(kp))

ffd = cv.FastFeatureDetector_create()
kp = ffd.detect(image)
print(len(kp))

afd = cv.AgastFeatureDetector_create()
kp = afd.detect(image)
print(len(kp))

gftt = cv.GFTTDetector_create()
kp = gftt.detect(image)
print(len(kp))

kaze = cv.KAZE_create()
kp = kaze.detect(image)
print(len(kp))

akaze = cv.AKAZE_create()
kp = akaze.detect(image)
print(len(kp))

@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Oct 19, 2018

@huningxin, May I ask you how to debug emscripten compilation?
The problem is that using the latest versions (i.e. 1.38.13) one of our tests is failed:

opencv/modules/js/test/test_imgproc.js

Lines 477 to 484 in 2180a67

cv.max(mat1, mat2, mat3);
// Verify result.
size = mat2.size();
assert.equal(mat2.channels(), 1);
assert.equal(size.height, 3);
assert.equal(size.width, 3);
assert.deepEqual(mat3.data, expectedMax);

I found that the following loop is a source of wrong values in src2:

opencv/modules/core/src/arithm_core.hpp

Lines 209 to 219 in 2180a67

#if CV_ENABLE_UNROLLED
for( ; x <= width - 4; x += 4 )
{
T v0 = op(src1[x], src2[x]);
T v1 = op(src1[x+1], src2[x+1]);
dst[x] = v0; dst[x+1] = v1;
v0 = op(src1[x+2], src2[x+2]);
v1 = op(src1[x+3], src2[x+3]);
dst[x+2] = v0; dst[x+3] = v1;
}
#endif

alalek
alalek reviewed Oct 20, 2018
View reviewed changes
modules/js/test/test_features2d.js Outdated
let image = new cv.Mat(100, 100, cv.CV_8UC1);
let low = new cv.Mat(1, 1, cv.CV_8UC1, [0, 0, 0, 0]);
let high = new cv.Mat(1, 1, cv.CV_8UC1, [255, 255, 255, 255]);
cv.randu(image, low, high);
Copy link
Copy Markdown
Member

@alalek alalek Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Avoid using of random images for keypoint detectors. Their implementations are not stable (not bit-exact between platforms).

Try to generate some synthetic frame instead:

function generateTestFrame(width, height) {
  let w = width || 200;
  let h = height || 200;
  let img = new cv.Mat(h, w, cv.CV_8UC1, new cv.Scalar(0, 0, 0, 0));
  let s0 = new cv.Scalar(0, 0, 0, 0);
  let s = new cv.Scalar(255, 255, 255, 255);
  let s128 = new cv.Scalar(128, 128, 128, 128);
  let rect = new cv.Rect(w / 4, h / 4, w / 2, h / 2);
  img.roi(rect).setTo(s);
  img.roi(new cv.Rect(w / 2 - w / 8, h / 2 - h / 8, w / 4, h / 4)).setTo(s128);
  cv.rectangle(img, new cv.Point(w / 8, h / 8), new cv.Point(w - w / 8, h - h / 8), s, 5);
  cv.rectangle(img, new cv.Point(w / 5, h / 5), new cv.Point(w - w / 5, h - h / 5), s128, 3);
  cv.line(img, new cv.Point(-w, 0), new cv.Point(w / 2, h / 2), s128, 5);
  cv.line(img, new cv.Point(2*w, 0), new cv.Point(w / 2, h / 2), s, 5);
  return img;
}

...
    let image = generateTestFrame();
  1. "low", "high" are not used.

Copy link
Copy Markdown
Member Author

@dkurt dkurt Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Done

platforms/js/build_js.py
"-DWITH_GPHOTO2=OFF",
"-DWITH_LAPACK=OFF",
"-DWITH_ITT=OFF",
"-DWITH_QUIRC=OFF",
Copy link
Copy Markdown
Member

@alalek alalek Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it changed?

Copy link
Copy Markdown
Member Author

@dkurt dkurt Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quirc is a dependency of QRCodeDetector which has no wrappers yet.

opencv/modules/objdetect/include/opencv2/objdetect.hpp

Line 670 in edacd91

class CV_EXPORTS QRCodeDetector

@allnes, Could you wrap it to python/java and add to the following file for JS bindings:

opencv/modules/js/src/embindgen.py

Lines 118 to 120 in edacd91

objdetect = {'': ['groupRectangles'],
'HOGDescriptor': ['load', 'HOGDescriptor', 'getDefaultPeopleDetector', 'getDaimlerPeopleDetector', 'setSVMDetector', 'detectMultiScale'],
'CascadeClassifier': ['load', 'detectMultiScale2', 'CascadeClassifier', 'detectMultiScale3', 'empty', 'detectMultiScale']}

@huningxin
Copy link
Copy Markdown
Contributor

huningxin commented Oct 23, 2018

Thank you folks! I am attending conference this week. The response is slow. Sorry for that.

@huningxin
Copy link
Copy Markdown
Contributor

huningxin commented Oct 25, 2018

@sajjadt, are you able to take a look? Thanks!

@dkurt dkurt mentioned this pull request Nov 26, 2018
Closed
@dkurt dkurt force-pushed the js_features2d_tests branch from 1658ea7 to 05665f3 Compare December 24, 2018 11:54
@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Dec 24, 2018

@alalek, @huningxin, It looks like the problem is solved. I tried to build this branch with emscripten 1.38.21 and all the tests are passed.

@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 27, 2018

Updated emscipten on linux-1: 1.38.21

Tests fails with latest LTS version of node (10.15.0), so downgraded on previous --lts=carbon (https://github.com/nodejs/Release):

+ node --version
v8.15.0
+ npm --version
6.4.1

@dkurt dkurt mentioned this pull request Jan 17, 2019
Closed
@dkurt dkurt mentioned this pull request Jan 28, 2019
Closed
@alalek alalek mentioned this pull request Jan 29, 2019
Merged
@dkurt dkurt force-pushed the js_features2d_tests branch from 05665f3 to 8ecc5e6 Compare February 1, 2019 16:15
alalek
alalek approved these changes Feb 2, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 8ecc5e6 into opencv:3.4 Feb 2, 2019
opencv-pushbot pushed a commit that referenced this pull request Feb 2, 2019
@alalek
Merge pull request #12855 from dkurt:js_features2d_tests
b19bb95
@alalek alalek mentioned this pull request Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: features2d category: javascript (js) test

Projects

None yet

Milestone

3.4.6

Development

Successfully merging this pull request may close these issues.

4 participants

@dkurt @huningxin @alalek @opencv-pushbot