Skip to content

JS: Improve enums support#12601

Merged
alalek merged 2 commits intoopencv:masterfrom
cv3d:fix/js
Sep 21, 2018
Merged

JS: Improve enums support#12601
alalek merged 2 commits intoopencv:masterfrom
cv3d:fix/js

Conversation

@cv3d
Copy link
Copy Markdown
Contributor

@cv3d cv3d commented Sep 20, 2018

Enums support in JS module was not complete! If an enum is utilized in a constructor or a const, it would fail such as in this build..
This PR fixes the issue

This pullrequest changes

  • Support enum types in constructors
  • Cast enum consts to their numeric values
force_builders=Custom
docker_image:Docs=docs-js
docker_image:Custom=javascript

@cv3d cv3d force-pushed the fix/js branch 3 times, most recently from 14f4008 to 6e3735a Compare September 20, 2018 15:35
@alalek alalek merged commit 84ae809 into opencv:master Sep 21, 2018
@cv3d cv3d deleted the fix/js branch September 22, 2018 12:33
AhiyaHiya pushed a commit to AhiyaHiya/opencv that referenced this pull request Sep 27, 2018
* master: (286 commits)
  Merge pull request opencv#12608 from dmatveev:gapi
  M_PI changed to CV_PI (opencv#12645)
  dnn: fix printf format warning
  Merge pull request opencv#12615 from D-Alex:master
  Fixed several incorrect printf format specifiers
  core: fix printf warnings by using c++11 format
  core: enable printf format warnings for cv::format
  JS: Support enum properties
  fix a bug in OpenGL
  samples: update winpack python samples launcher
  Merge pull request opencv#12310 from cv3d:chunks/enum_interface
  Merge pull request opencv#12601 from cv3d:fix/js
  release: OpenCV 4.0.0-alpha (version++)
  cuda: move CUDA modules to opencv_contrib
  cmake: update install paths (Linux)
  Merge pull request opencv#12570 from alalek:drop_usrtype1
  Fix failure to request stddev of non-intrinsics
  ts: update valgrind test filter
  build: fix Xcode 10 build problems
  Enable Myriad device for OpenVINO models test
  ...
dkurt added a commit to dkurt/opencv that referenced this pull request Mar 13, 2019
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
* JS: Support enum types in constructors

* JS: Avoid unary expression on enum-based consts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants