Skip to content

dnn(test): fix failures of 32-bit builders#12502

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:fix_dnn_tests_32bit
Sep 13, 2018
Merged

dnn(test): fix failures of 32-bit builders#12502
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:fix_dnn_tests_32bit

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Sep 11, 2018 •
edited
Loading

No description provided.

dkurt
dkurt reviewed Sep 12, 2018
View reviewed changes
modules/dnn/test/test_onnx_importer.cpp
TEST_P(Test_ONNX_nets, DISABLED_VGG16_bn) // memory usage >2Gb
#else
TEST_P(Test_ONNX_nets, VGG16_bn)
#endif
Copy link
Copy Markdown
Member

@dkurt dkurt Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it observed for both Linux and Windows configs? In example, there is a test which is skipped only for Win32 builds:

opencv/modules/dnn/test/test_caffe_importer.cpp

Lines 154 to 155 in 10ae0c4

#if !defined(_WIN32) || defined(_WIN64)
TEST(Reproducibility_FCN, Accuracy)

Copy link
Copy Markdown
Member Author

@alalek alalek Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests use ~2.5Gb RAM, so it is better to disable them on any 32-bit configuration.
It would be nice to disable for 32-bit configurations other tests too which require >1Gb RAM.

@vpisarev vpisarev self-assigned this Sep 12, 2018
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Sep 12, 2018 •
edited
Loading

BUILD_32BIT looks a bit weird name to me, can we have some CV_ or OPENCV_ prefix?

Also, we have a special macro to mark the tests that consume a lot of memory (BIG_DATA_TEST or something like that). Can we just re-use it here?

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Sep 12, 2018 •
edited
Loading

My current assumption about BIG_DATA_TEST() is that it handles tests which use 4+Gb RAM (and it was added for 64-bit configurations).
Perhaps we need to add additional BIGDATA macros for 512Mb, 1Gb, 2Gb, 4Gb, 7Gb, 15Gb memory limits.

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Sep 12, 2018

Lets merge it "as is" to make builds green again (patch is not large).
Future improvements can be added by next PRs.

@alalek alalek assigned mshabunin and unassigned vpisarev Sep 13, 2018
@opencv-pushbot opencv-pushbot merged commit 6fc8558 into opencv:3.4 Sep 13, 2018
opencv-pushbot pushed a commit that referenced this pull request Sep 13, 2018
@alalek
Merge pull request #12502 from alalek:fix_dnn_tests_32bit
e51d7cb
@alalek alalek mentioned this pull request Sep 14, 2018
Merged
@alalek alalek mentioned this pull request Oct 9, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt left review comments

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

category: dnn test

Projects

None yet

Milestone

3.4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@alalek @vpisarev @mshabunin @dkurt @opencv-pushbot