Skip to content

Improvments/cuda detection#12224

Merged
opencv-pushbot merged 2 commits intoopencv:masterfrom
cv3d:improvments/CUDA_detection
Aug 16, 2018
Merged

Improvments/cuda detection#12224
opencv-pushbot merged 2 commits intoopencv:masterfrom
cv3d:improvments/CUDA_detection

Conversation

@cv3d
Copy link
Copy Markdown
Contributor

@cv3d cv3d commented Aug 16, 2018 •
edited by alalek
Loading

This pullrequest changes

  • Since CUDA_HOST_COMPILER is set to $(VCInstallDir)bin in case of Win VS, CUDA archs detection (CUDA_GENERATION=Auto) fails. This PR solve such an issue.
  • In case of multiple cards installed , detected archs might get repeated if the devices are of the same arch. This PR solve this issue as well. The detection code is upgraded to C++ to simplify the task.

BTW: To avoid making two PRs for related issues, I have utilized two commits for two separate, but related issues.

force_builders=Docs,linux,linux32,ocllinux,linuxNoOpt,ocl,windows,win32,macosx,oclmacosx,ios,android,Custom
docker_image:Custom=ubuntu-cuda:16.04
allow_multiple_commits=1

@cv3d cv3d force-pushed the improvments/CUDA_detection branch from 0375ace to e136c11 Compare August 16, 2018 08:40
alalek
alalek approved these changes Aug 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit e136c11 into opencv:master Aug 16, 2018
opencv-pushbot pushed a commit that referenced this pull request Aug 16, 2018
@alalek
Merge pull request #12224 from cv3d:improvments/CUDA_detection
4e59d6f
@cv3d cv3d deleted the improvments/CUDA_detection branch August 16, 2018 10:02
@alalek alalek mentioned this pull request Jun 21, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: build/install category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib

Projects

None yet

Milestone

4.0.0-alpha

Development

Successfully merging this pull request may close these issues.

3 participants

@cv3d @alalek @opencv-pushbot