cmake download workaround, samples data installation#12124
Merged
opencv-pushbot merged 2 commits intoopencv:3.4from Aug 2, 2018
Merged
cmake download workaround, samples data installation#12124opencv-pushbot merged 2 commits intoopencv:3.4from
opencv-pushbot merged 2 commits intoopencv:3.4from
Conversation
alalek
reviewed
Aug 1, 2018
samples/dnn/CMakeLists.txt
Outdated
| "${OPENCV_DNN_MODELS_URL}" | ||
| "https://raw.githubusercontent.com/opencv/opencv_3rdparty/${commit}/" | ||
| DESTINATION_DIR ${DNN_FACE_DETECTOR_MODEL_DOWNLOAD_DIR} | ||
| DESTINATION_DIR "${OpenCV_BINARY_DIR}/face_detector" |
Member
There was a problem hiding this comment.
It is located in the source directory for a reason.
There are other files which required to run sample.
Python sample goes broken (they are run from source directory).
…_detector models in cmake
2f7ed60 to
df9efbb
Compare
alalek
approved these changes
Aug 2, 2018
opencv-pushbot
pushed a commit
that referenced
this pull request
Aug 2, 2018
This was referenced Aug 7, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
How to use download scripts
bash <build>/download_with_wget.shscript (or with_curl) - all files will be downloaded to the download cachecmake .in the build directory - all downloaded files will be found by cmakeHow to download face_detector models
python download_weights.pyAlternative way:
weights.meta4file to it, e.g.aria2c weights.meta4