Skip to content

WinRT API certification fixes.#1205

Merged
opencv-pushbot merged 4 commits intoopencv:2.4from
asmorkalov:winrt_api_cert_fix
Aug 2, 2013
Merged

WinRT API certification fixes.#1205
opencv-pushbot merged 4 commits intoopencv:2.4from
asmorkalov:winrt_api_cert_fix

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

All restricted WIN32 API replaced with analogues for all modules, except ts and highgui;
ENABLE_WINRT_MODE cmake option added.

@ghost ghost assigned apavlenko Jul 30, 2013
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you use either new or cv::fastMalloc().
Also it may be good to use cv::Ptr<> for auto-free.

@apavlenko
Copy link
Copy Markdown
Contributor

BTW, do you know it fails to build on Windows?
(http://build.opencv.org/builders/precommit_windows/builds/4526)

philippefoubert pushed a commit to philippefoubert/opencv that referenced this pull request Jul 30, 2013
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ptr<>?

WITH_WINRT -> ENABLE_WINRT_MODE;
Some temporary char* replaced with Ptr<char>;
Build fix for regular WIN32;
Windows Platform SDK and MSVC search added to cmake;
Warinig fixes.
@apavlenko
Copy link
Copy Markdown
Contributor

👍

@opencv-pushbot opencv-pushbot merged commit 63786c3 into opencv:2.4 Aug 2, 2013
@SpecLad SpecLad mentioned this pull request Aug 6, 2013
@asmorkalov asmorkalov deleted the winrt_api_cert_fix branch January 19, 2014 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants