Warning suppresion for TBB on WinRT added.#1169
Merged
opencv-pushbot merged 1 commit intoopencv:2.4from Jul 24, 2013
Merged
Conversation
Contributor
|
@SpecLad Roman, could you please review? |
3rdparty/tbb/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Why did you remove the previously disabled warnings? And why didn't you use ocv_warnings_disable for this one?
Contributor
Author
There was a problem hiding this comment.
ocv_warnings_disable macro just remove key from CMAKE_CXX_FLAGS. -Wunused-parameter is not relevant for cl.exe. We do not set warning level for WinRT, so /wd is the only solution.
There was a problem hiding this comment.
I'm pretty sure ocv_warnings_disable will append your flag. I mean, look at the source.
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning appears in TBB headers in case of Debug build.