Added the sample from patch #2288 : reading in sequence of images#1166
Added the sample from patch #2288 : reading in sequence of images#1166opencv-pushbot merged 1 commit intoopencv:masterfrom StevenPuttemans:patch_2288
Conversation
|
@StevenPuttemans Thank you for PR, could you please fix build: http://pullrequest.opencv.org/? |
|
Ill try to have a look at what goes wrong :) It is not that easy to understand, but I will do my best! |
|
Lets see if problems are solved now. It seems that this were the two main causes of error. |
|
@ivan-korolev Build fixed, it seems all tests are passed now. |
|
@StevenPuttemans Thanks you! Could you please combine the commits into 1 so that we have a clear history in the repository? |
|
Well people told me I could do this using the rebase command. However, last time I did that I completely screwed up my pull request and had to make a new one. Could you explain me the rebase command to merge the last 4 commits? |
|
Found myself a good guide, mastered the rebase technique :) Tested it on other pull request, will do it here also. |
|
Build fixed, commits merged into single one! Ready to merge I guess. |
|
@StevenPuttemans Thank you! |
samples/cpp/image_sequence.cpp
Outdated
There was a problem hiding this comment.
Help text is a bit inconsistent: example_%%02d.jpg isn't the 1st image file name but the mask.
It also would be great to explain how the mask relates to file names (e.g. 'the mask "example_%%02d.jpg" means reading images named as "example_00.jpg", "example_01.jpg", etc.')
Added bugfixes - Changed CV_WINDOW_NORMAL to 1 - Changed the help function to static - Added extra help information on mask specifics
|
Adapted and rebased to single commit. |
|
👍 |
|
👍 |
Submitted the sample suggested in patch #2288 (http://code.opencv.org/issues/2288).
Remark: