Skip to content

Add ocl::gftt performance test.#1121

Merged
opencv-pushbot merged 2 commits intoopencv:2.4from
pengx17:2.4_gftt_perf_test
Jul 30, 2013
Merged

Add ocl::gftt performance test.#1121
opencv-pushbot merged 2 commits intoopencv:2.4from
pengx17:2.4_gftt_perf_test

Conversation

@pengx17
Copy link
Copy Markdown
Contributor

@pengx17 pengx17 commented Jul 15, 2013

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Jul 15, 2013

Hi,

Could you please look at compilation errors? (http://build.opencv.org/builders/precommit_macos/builds/4156)

/Users/user/slave/builds/precommit_macos/src/opencv/modules/ocl/perf/perf_gftt.cpp:61:32: error: comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare]
for(int imgIdx = 0; imgIdx < sizeof(images)/sizeof(std::string); ++imgIdx)
~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [modules/ocl/CMakeFiles/opencv_perf_ocl.dir/perf/perf_gftt.cpp.o] Error 1

@ghost ghost assigned Nerei Jul 16, 2013
@ghost
Copy link
Copy Markdown

ghost commented Jul 16, 2013

Anatoly,

Could you please look at the pull request?

@ghost ghost assigned apavlenko Jul 21, 2013
@apavlenko
Copy link
Copy Markdown
Contributor

It conforms to other ocl perf tests but doesn't conform to all non-ocl OpenCV perf tests.
So for now it's 👍 , but in nearest future all the ocl perf tests need to be refactored and implemented based on gtestand perf frameworks...

@opencv-pushbot opencv-pushbot merged commit ff73557 into opencv:2.4 Jul 30, 2013
@SpecLad SpecLad mentioned this pull request Aug 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants