Fixed issue in ORB detection if firstLevel property is set above 0#10690
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Feb 1, 2018
Merged
Fixed issue in ORB detection if firstLevel property is set above 0#10690opencv-pushbot merged 1 commit intoopencv:masterfrom
opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
alalek
reviewed
Jan 26, 2018
Member
alalek
left a comment
There was a problem hiding this comment.
Please add regression test for this.
| roughly match the patchSize parameter. | ||
| @param firstLevel It should be 0 in the current implementation. | ||
| @param firstLevel The level of pytramid to put source image to. Previous layers are filled | ||
| with upscaled source image. |
| int getEdgeThreshold() const { return edgeThreshold; } | ||
|
|
||
| void setFirstLevel(int firstLevel_) { firstLevel = firstLevel_; } | ||
| void setFirstLevel(int firstLevel_) { CV_Assert(firstLevel >= 0); firstLevel = firstLevel_; } |
Member
There was a problem hiding this comment.
Parameter name contains underscore: firstLevel_, assertion - doesn't.
Contributor
|
👍 |
opencv-pushbot
pushed a commit
that referenced
this pull request
Feb 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #10561
This pullrequest changes
Fixed pyramid buffer size to allow retaining of upscaled images. Updated pyramid evaluation to perform image upscaling if necessary.