solves issue #10687#10688
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Jan 26, 2018
LaurentBerger:calcback
Merged
solves issue #10687#10688opencv-pushbot merged 1 commit intoopencv:masterfrom LaurentBerger:calcback
opencv-pushbot merged 1 commit intoopencv:masterfrom
LaurentBerger:calcback
Conversation
savuor
reviewed
Jan 26, 2018
modules/imgproc/src/histogram.cpp
Outdated
| { | ||
| CV_INSTRUMENT_REGION() | ||
|
|
||
| if (hist.dims() != 3) |
Contributor
There was a problem hiding this comment.
It's better to compare like that: if(hist.dims() <= 2) to avoid histograms of higher dimensions.
Contributor
|
👍 |
opencv-pushbot
pushed a commit
that referenced
this pull request
Jan 26, 2018
Member
|
BTW, New functionality should be covered by tests. |
Contributor
Author
|
@alalek what do you mean? calcBackProject is not tested (except in 8 tests from OCL_Imgproc/CalcBackProject)? or 3d calcbackproject? |
Member
|
I mean that 3D case is not tested. We need some test to avoid future regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #10687