Skip to content

PvAPI support on Windows with MinGW (see Patch #2083)#1038

Closed
philippefoubert wants to merge 1 commit intoopencv:masterfrom
philippefoubert:branch_pvapi
Closed

PvAPI support on Windows with MinGW (see Patch #2083)#1038
philippefoubert wants to merge 1 commit intoopencv:masterfrom
philippefoubert:branch_pvapi

Conversation

@philippefoubert
Copy link
Copy Markdown
Contributor

Add a define to avoid unresolved externals when compiling with MinGW

@ghost ghost assigned SpecLad Jun 27, 2013
@kirill-korniakov
Copy link
Copy Markdown

Roman, could you please review. MinGW or Windows beta-testers are also invited to participate.

@SpecLad
Copy link
Copy Markdown

SpecLad commented Jun 27, 2013

@philippefoubert It seems like this patch applies to the 2.4 branch, as well as master. If that is the case, please close this pull request and resubmit against 2.4.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only happen when HAVE_PVAPI is true, and only for the modules that use it (that is, only for highgui). I would suggest you add a variable named PVAPI_DECLARATIONS here, and use it in highgui's CMakeLists.txt.

@mdim
Copy link
Copy Markdown
Contributor

mdim commented Jul 2, 2013

@philippefoubert could you please add the changes recommend by SpecLad?

philippefoubert added a commit to philippefoubert/opencv that referenced this pull request Jul 2, 2013
@StevenPuttemans
Copy link
Copy Markdown

@philippefoubert can you confirm that this fix got in OpenCV through another pull request? Trying to clean up the bug issue section and for this one it is not clear if it got in or not :P

savuor pushed a commit to nickyu-zhu/opencv that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants