OCL: avoid unnecessary loading/initializing OpenCL subsystem#10180
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Nov 29, 2017
Merged
Conversation
If there are no OpenCL/UMat methods calls from application. OpenCL subsystem is initialized: - haveOpenCL() is called from application - useOpenCL() is called from application - access to OpenCL allocator: UMat is created (empty UMat is ignored) or UMat <-> Mat conversions are called Don't call OpenCL functions if OPENCV_OPENCL_RUNTIME=disabled (independent from OpenCL linkage type)
Contributor
|
@alalek, looks like there are many changes where good old cv::ocl::useOpenCL() is replaced with cv::ocl::isOpenCLActivated(). Can we somehow provide better backward compatibility, i.e. adjust cv::ocl::useOpenCL() to suit the same purpose as cv::ocl::isOpenCLActivated()? |
Member
Author
According the current semantic of We just need to replace calls inside library itself only. The difference is that |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are no OpenCL/UMat methods calls from application.
OpenCL subsystem is initialized:
Don't call OpenCL functions if OPENCV_OPENCL_RUNTIME=disabled
(independent from OpenCL linkage type)