Poststop hooks receives correct pid#565
Closed
zachgersh wants to merge 1 commit intoopencontainers:masterfrom
Closed
Poststop hooks receives correct pid#565zachgersh wants to merge 1 commit intoopencontainers:masterfrom
zachgersh wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Gabe Rosenhouse <grosenhouse@pivotal.io>
Member
|
Since this is the post stop hook the pid was set to 0 because it is no longer alive. What is the usecase for providing this? |
|
You're right -- we were confused about the lifecycle here. We will close this. |
Member
|
No problem, thanks! |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Windows: User struct changes
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
We dropped these in 4774080 (specs-go/config: Drop "this field is platform dependent", 2016-09-14, opencontainers#568) but f9e48e0 (Windows: User struct changes, 2016-09-14, opencontainers#565) was developed in parallel and brought in a new one. Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While developing a poststop hook, we discovered that the container state provided on stdin always had
pidset to0.This patch sets the
pidfield correctly.cc: @rosenhouse @evanfarrar