[1.4] CI: fix modernize job failure#5074
Merged
rata merged 4 commits intoopencontainers:release-1.4from Dec 20, 2025
Merged
Conversation
Generated by modernize@latest (v0.21.0). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 6522697) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Since we use modernize@latest, it may require latest Go as well (and now it does), so use "go-version: stable" explicitly (which resolves to latest Go). This fixes the issue with CI: > go: golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest: golang.org/x/tools/gopls@v0.21.0 requires go >= 1.25 (running go 1.24.11; GOTOOLCHAIN=local) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 16ee2bb) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The modernize documentation used to suggest -test flag but it's not needed as it is enabled by default. Drop it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit dbc4234) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 428043b) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Merged
cyphar
approved these changes
Dec 20, 2025
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Mar 12, 2026
Note a few minor PRs were not mentioned: opencontainers#5134, opencontainers#5094, opencontainers#5074. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Mar 12, 2026
Note a few minor PRs were not mentioned: opencontainers#5134, opencontainers#5094, opencontainers#5074. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Mar 12, 2026
Note a few minor PRs were not mentioned: opencontainers#5134, opencontainers#5094, opencontainers#5074. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Mar 12, 2026
Note a few minor PRs were not mentioned: opencontainers#5134, opencontainers#5094, opencontainers#5074. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Mar 12, 2026
Note a few minor PRs were not mentioned: opencontainers#5134, opencontainers#5094, opencontainers#5074. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Mar 12, 2026
Note a few minor PRs were not mentioned: opencontainers#5134, opencontainers#5094, opencontainers#5074. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
to release-1.4 branch.
The alternative to this is to drop
modernizejob (it does not make much sense for a release branch).libc/int: use strings.Builder
Generated by modernize@latest (v0.21.0).
ci: use latest Go for modernize job
Since we use modernize@latest, it may require latest Go as well (and now it does),
so use "go-version: stable" explicitly (which resolves to latest Go).
This fixes the issue with CI:
ci: drop -test from modernize run
The modernize documentation used to suggest -test flag but it's not
needed as it is enabled by default. Drop it.
ci: fix modernize url
See https://go.dev/cl/706918, https://go.dev/cl/730820.