Skip to content

Add loong64 support in seccomp and PIE#4938

Merged
AkihiroSuda merged 2 commits intoopencontainers:mainfrom
zhaixiaojuan:main
Oct 22, 2025
Merged

Add loong64 support in seccomp and PIE#4938
AkihiroSuda merged 2 commits intoopencontainers:mainfrom
zhaixiaojuan:main

Conversation

@zhaixiaojuan
Copy link
Copy Markdown
Contributor

@zhaixiaojuan zhaixiaojuan commented Oct 16, 2025

I resubmitted a PR to replace #3765

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at:
https://loongson.github.io/LoongArch-Documentation/README-EN.html

@yzewei
Copy link
Copy Markdown

yzewei commented Oct 16, 2025

LGTM!

@lifubang
Copy link
Copy Markdown
Member

I'll approve to run the CI, but don’t forget to sign off your commit!

@lifubang
Copy link
Copy Markdown
Member

There are two questions:

  1. We might also need to update the documentation regarding the supported architectures:
    https://github.com/zhaixiaojuan/runc/blob/be0377ce139f0a406d3d0f472d5c1b1f7e625053/docs/spec-conformance.md?plain=1#L14
  2. Relatedly, have you actually tested this support on a LoongArch64 (loong64) machine?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: zhaixiaojuan <zhaixiaojuan@loongson.cn>
@zhaixiaojuan
Copy link
Copy Markdown
Contributor Author

  1. Relatedly, have you actually tested this support on a LoongArch64 (loong64) machine?

For LoongArch, since there is no Ubuntu system, we tested it on the Debian system and it can be used normally. Debian upstream has already released runc package: http://ftp.ports.debian.org/debian-ports/pool-loong64/main/r/runc/

Here are links for submitting LoongArch runc patches to Debian upstream:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069166
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095452

LoongArch runc packages have also been released for OpenEuler and Anolis systems:
https://repo.openeuler.org/openEuler-24.03-LTS/OS/loongarch64/Packages/
https://mirrors.openanolis.cn/anolis/23.2/os/loongarch64/os/Packages/

@lifubang lifubang added the backport/1.4-todo A PR in main branch which needs to backported to release-1.4 label Oct 21, 2025
@zhaixiaojuan
Copy link
Copy Markdown
Contributor Author

@lifubang
Hi, I checked the test failures for "test (ubuntu-24.04, 1.25.x, criu-dev)" and it seems to be unrelated to the modified code.

@AkihiroSuda AkihiroSuda merged commit 7f32e50 into opencontainers:main Oct 22, 2025
54 of 55 checks passed
@h-vetinari h-vetinari mentioned this pull request Nov 28, 2025
13 tasks
@wojiushixiaobai
Copy link
Copy Markdown

Hi,

I noticed that the following patch appears to be missing from the release:v1.4.0

It seems that this patch was referenced or intended to be included, but it does not appear in the v1.4.0 build or commit history.
Could you confirm whether this was intentionally excluded or if it was accidentally omitted?

Thanks.

@lifubang
Copy link
Copy Markdown
Member

lifubang commented Dec 8, 2025

I think we should add a 1.4.x milestone to this PR; otherwise, it won’t be included in any release.

Could you please open a backport PR against the release-1.4 branch? If not, I’ll go ahead and create one when I get a chance.

@lifubang lifubang added this to the 1.4.1 milestone Dec 8, 2025
@kolyshkin kolyshkin added backport/1.4-done A PR in main branch which has been backported to release-1.4 and removed backport/1.4-todo A PR in main branch which needs to backported to release-1.4 labels Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.4-done A PR in main branch which has been backported to release-1.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants