docs: update libcontainer README for external cgroups repo#4786
Closed
eyasy1217 wants to merge 2 commits into
Closed
docs: update libcontainer README for external cgroups repo#4786eyasy1217 wants to merge 2 commits into
eyasy1217 wants to merge 2 commits into
Conversation
Signed-off-by: eyasy1217 <yuyi4145@gmail.com>
kolyshkin
requested changes
Jun 19, 2025
kolyshkin
left a comment
Contributor
There was a problem hiding this comment.
While at it, maybe you can add the missing "includes" section, which should clarify things.
Author
Does that mean I should put the import statements inside the Container creation code? +import (
+ "github.com/opencontainers/cgroups"
+ _ "github.com/opencontainers/cgroups/devices"
+ "github.com/opencontainers/cgroups/devices/config"
+ "github.com/opencontainers/runc/libcontainer/configs"
+ _ "github.com/opencontainers/runc/libcontainer/nsenter"
+ "github.com/opencontainers/runc/libcontainer/specconv"
+ "golang.org/x/sys/unix"
+ // ...
+)
+// ...
defaultMountFlags := unix.MS_NOEXEC | unix.MS_NOSUID | unix.MS_NODEV
var devices []*config.Rule
for _, device := range specconv.AllowedDevices {
devices = append(devices, &device.Rule)
} |
Contributor
|
Yes, I meant import, not includes :) Ideally though, these code samples should be placed out of README and into some Go files so that they at least can be test-compiled. Or, README can point out to real code in runc which can also serve as an example. |
Signed-off-by: eyasy1217 <yuyi4145@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs. #4638