Switch to github.com/opencontainers/cgroups#4638
Merged
cyphar merged 1 commit intoopencontainers:mainfrom Mar 1, 2025
Merged
Conversation
5 tasks
986f5e2 to
f691f4d
Compare
Contributor
|
❤️ |
4b6c7c8 to
92e997a
Compare
Member
|
I've merged opencontainers/cgroups#1. |
rata
reviewed
Feb 28, 2025
Member
rata
left a comment
There was a problem hiding this comment.
@kolyshkin thanks! This looks rather trivial, after you remove the replace in the go.mod, this LGTM :)
92e997a to
ae28444
Compare
ae28444 to
fcb453d
Compare
This removes libcontainer/cgroups packages and starts
using those from github.com/opencontainers/cgroups repo.
Mostly generated by:
git rm -f libcontainer/cgroups
find . -type f -name "*.go" -exec sed -i \
's|github.com/opencontainers/runc/libcontainer/cgroups|github.com/opencontainers/cgroups|g' \
{} +
go get github.com/opencontainers/cgroups@v0.0.1
make vendor
gofumpt -w .
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
fcb453d to
a75076b
Compare
lifubang
approved these changes
Mar 1, 2025
Member
lifubang
left a comment
There was a problem hiding this comment.
LGTM
Let's hope there will be no commits need to backport to release-1.2 in cgroups area in the future.
7 tasks
winkingturtle-vmw
added a commit
to cloudfoundry/guardian
that referenced
this pull request
Apr 30, 2025
from opencontainers/runc/libcontainer/cgroups Context: opencontainers/runc#4638
1 task
winkingturtle-vmw
added a commit
to cloudfoundry/guardian
that referenced
this pull request
Apr 30, 2025
from opencontainers/runc/libcontainer/cgroups Context: opencontainers/runc#4638
ebroberson
pushed a commit
to cloudfoundry/guardian
that referenced
this pull request
Apr 30, 2025
from opencontainers/runc/libcontainer/cgroups Context: opencontainers/runc#4638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a draft pending the merge of opencontainers/cgroups#1.This removes libcontainer/cgroups packages and starts
using those from github.com/opencontainers/cgroups repo.
Mostly generated by:
For #4618.