libcontainer: rm windows pieces (carry #2700)#2888
Merged
kolyshkin merged 5 commits intoopencontainers:masterfrom Apr 4, 2021
Merged
libcontainer: rm windows pieces (carry #2700)#2888kolyshkin merged 5 commits intoopencontainers:masterfrom
kolyshkin merged 5 commits intoopencontainers:masterfrom
Conversation
Nothing is in there, so removing. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was initially added by commit d78ee47 but later moved from libcontainer/configs to libcontainer/devices by commit 677baf2. Looks like since commit 677baf2 and also [1] there is no use for this, thus removing. [1] containers/buildah#2652 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Commit bf74951 added these two functions, but they are only used from Windows code. The v1 of this patch moved these functions to _windows.go file, but after some discussion we decided to drop windows code altogether, so this is what this patch now does. This fixes > libcontainer/user/user.go:64:6: func `groupFromOS` is unused (unused) > libcontainer/user/user.go:35:6: func `userFromOS` is unused (unused) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Move the unix-specific code to a file that's not compiled on Windows. Some of the errors (ErrUnsupported, ErrNoPasswdEntries, ErrNoGroupEntries) are used in other parts of the code, so are moved to a non-platform specific file. Most of "user" is probably not useful on Windows, although it's possible that Windows code may have to parse a passwd file, so leaving that code for now. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
centos failed to start, so closed/reopened to trigger again |
Member
Author
|
All green now 🎉 @kolyshkin @AkihiroSuda PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carry of #2700
closes #2700
Rebased the branch, and included kolyshkin#9.
I also opened draft PR's to run CI in moby and containerd with this branch in moby/moby#42143 and containerd/containerd#5301