Skip to content

go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210408171205-2d38476c96e3#5301

Closed
thaJeztah wants to merge 1 commit intocontainerd:masterfrom
thaJeztah:check_libcontainer
Closed

go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210408171205-2d38476c96e3#5301
thaJeztah wants to merge 1 commit intocontainerd:masterfrom
thaJeztah:check_libcontainer

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 2, 2021 •
edited
Loading

relates to opencontainers/runc#2700 testing those changes to verify nothing breaks terribly
depends on / rebased on top of #5324 merged

full diff: opencontainers/runc@v1.0.0-rc93...2d38476

Two extra commits were added to help the renaming of readme.md to README.md (done in cilium/ebpf@98e04fb / cilium/ebpf@b48cbe8 / cilium/ebpf#185)

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 2, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 2, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 2, 2021

Some interesting failures in https://pipelines.actions.githubusercontent.com/G4SighzWVVZ6vsyiz7FFMFjLjRzveJHseEnVyibkSq87Cl2x4O/_apis/pipelines/1/runs/4631/signedlogcontent/73?urlExpires=2021-04-02T11%3A40%3A16.5390024Z&urlSigningMethod=HMACV1&urlSignature=HxKSYXNqTIkz0yXqRg4xf1dvei5fKDRuyNZQfiyn62s%3D

Looks flaky (are these known?)

rpc error: code = Unknown desc =
failed to pull and unpack image "gcr.io/cri-tools/test-image-digest@sha256:9179135b4b4cc5a8721e09379244807553c318d92fa3111a65133241551ca343":
failed to copy: httpReadSeeker: failed open:
unexpected status code https://gcr.io/v2/cri-tools/test-image-digest/blobs/sha256:268449409a783c0b51b294340457a2603fec06d259f51ab996463b5115de19f6: 403 Forbidden

(Same for the other runs); is the above causing the failures?

Summarizing 8 Failures:

[Fail] [k8s.io] Streaming runtime should support streaming interfaces [It] runtime should support portforward in host network
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

[Fail] [k8s.io] Image Manager [It] image status should support all kinds of references [Conformance]
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

[Fail] [k8s.io] Image Manager [It] public image without tag should be pulled and removed [Conformance]
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

[Fail] [k8s.io] Image Manager [It] listImage should get exactly 3 repoTags in the result image [Conformance]
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

[Fail] [k8s.io] Image Manager [It] public image with tag should be pulled and removed [Conformance]
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

[Fail] [k8s.io] Image Manager [It] listImage should get exactly 3 image in the result list [Conformance]
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

[Fail] [k8s.io] Image Manager [It] image status get image fields should not have Uid|Username empty [Conformance]
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

[Fail] [k8s.io] Image Manager [It] public image with digest should be pulled and removed [Conformance]
/tmp/tmp.g3WnxjXJVU/cri-tools/pkg/framework/util.go:352

@thaJeztah thaJeztah mentioned this pull request Apr 2, 2021
Merged
@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 69dae0b to 99e75f9 Compare April 4, 2021 20:54
@thaJeztah thaJeztah changed the title go.mod: test upcoming libcontainer changes go.mod: github.com/opencontainers/runc 365c6282c70a Apr 4, 2021
@thaJeztah

This comment has been minimized.

Sign in to view
@thaJeztah thaJeztah closed this Apr 4, 2021
@thaJeztah thaJeztah reopened this Apr 4, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 4, 2021

Build succeeded.

@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 99e75f9 to 969debc Compare April 7, 2021 17:23
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 7, 2021

Build succeeded.

@thaJeztah thaJeztah changed the title go.mod: github.com/opencontainers/runc 365c6282c70a go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210407001756-bb28c44f12bf Apr 8, 2021
@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 969debc to 092063c Compare April 8, 2021 08:46
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 8, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 8, 2021

Hmmm... new issues with gcr.io 😞

time="2021-04-08T09:03:56Z" level=info msg="start to pull seed image" image="mirror.gcr.io/library/busybox:latest"
failed to resolve reference "mirror.gcr.io/library/busybox:latest": mirror.gcr.io/library/busybox:latest: not found: time="2021-04-08T09:03:56.442858021Z" level=info msg="starting containerd" revision=a19b3b05ad66e275dd4d5bba9de0a518f5b5675a version=a19b3b0

@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 092063c to 5edd072 Compare April 8, 2021 09:30
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 8, 2021

Build succeeded.

@thaJeztah thaJeztah marked this pull request as ready for review April 8, 2021 09:46
@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 5edd072 to 79e6b49 Compare April 8, 2021 19:40
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 8, 2021

Build succeeded.

@thaJeztah thaJeztah changed the title go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210407001756-bb28c44f12bf go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210408171205-b23315bdd99c Apr 8, 2021
@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 79e6b49 to 2b36136 Compare April 8, 2021 21:34
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 8, 2021

temporarily moving back to draft as this will conflict with #5324, so I rebased on top of that

@thaJeztah thaJeztah marked this pull request as draft April 8, 2021 21:36
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 8, 2021

Build succeeded.

@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 2b36136 to b70a16d Compare April 9, 2021 00:43
@thaJeztah thaJeztah marked this pull request as ready for review April 9, 2021 00:43
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 9, 2021

Build succeeded.

@thaJeztah thaJeztah mentioned this pull request Apr 12, 2021
Closed
14 tasks
@thaJeztah thaJeztah force-pushed the check_libcontainer branch from b70a16d to 6727388 Compare April 12, 2021 23:16
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 12, 2021

Build succeeded.

@thaJeztah thaJeztah force-pushed the check_libcontainer branch from 6727388 to f40c684 Compare April 13, 2021 08:36
@thaJeztah thaJeztah changed the title go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210408171205-b23315bdd99c go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210408171205-2d38476c96e3 Apr 13, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 13, 2021

Build succeeded.

@thaJeztah thaJeztah closed this Apr 13, 2021
@thaJeztah thaJeztah reopened this Apr 13, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 13, 2021

Build succeeded.

@thaJeztah thaJeztah force-pushed the check_libcontainer branch from f40c684 to da15213 Compare April 19, 2021 13:32
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 19, 2021

Build succeeded.

@thaJeztah thaJeztah force-pushed the check_libcontainer branch from da15213 to f312575 Compare April 20, 2021 11:49
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 20, 2021

Build succeeded.

@thaJeztah
go.mod: github.com/opencontainers/runc v1.0.0-rc93.0.20210408171205-2…
be9ee23 
…d38476c96e3

full diff: opencontainers/runc@v1.0.0-rc93...2d38476

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the check_libcontainer branch from f312575 to be9ee23 Compare April 21, 2021 08:26
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Apr 21, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 21, 2021

/test pull-containerd-node-e2e

@estesp
Copy link
Copy Markdown
Member

estesp commented May 11, 2021

I think this can be closed due to the merge of #5473

@estesp estesp closed this May 11, 2021
@thaJeztah thaJeztah deleted the check_libcontainer branch May 12, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @k8s-ci-robot @estesp