tests/int: fix wrt busybox's nogroup->nobody change#2580
Merged
mrunalp merged 2 commits intoopencontainers:masterfrom Sep 9, 2020
Merged
tests/int: fix wrt busybox's nogroup->nobody change#2580mrunalp merged 2 commits intoopencontainers:masterfrom
mrunalp merged 2 commits intoopencontainers:masterfrom
Conversation
This test started to fail, as it expected the output from `id` to be uid=1000 gid=1000 groups=100(users),65534(nogroup) while the actual output is now uid=1000 gid=1000 groups=100(users),65534(nobody) Apparently, busybox image changed group name. As we're only interested in ids, not names, and to fix the test, let's use `id -G`. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
@AkihiroSuda @mrunalp PTAL |
Contributor
Author
|
Found while looking at CI for #2580 |
mrunalp
previously approved these changes
Sep 9, 2020
Contributor
|
@AkihiroSuda ptal |
Contributor
Author
|
Another failure caused by the same change: |
These tests expect group name to be "nogroup", while recent busybox changed that to "nobody". Use numeric uids/gids to fix. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
Sep 9, 2020
mrunalp
approved these changes
Sep 9, 2020
This was referenced Sep 9, 2020
|
I also hit the same issue, it's nobody not nogroup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, newer busybox image changed "nogroup" group name to "nobody",
breaking a few test cases that depended on the name.
Fix those tests by switching to numeric IDs.
1. tests/int: fix runc exec --preserve-fds
This test started to fail, as it expected the output from
idto bewhile the actual output is now
Apparently, busybox image changed group name.
As we're only interested in ids, not names, and to fix the test,
let's use
id -G.2. tests/int/dev.bats: fixes for new busybox
These tests expect group name to be "nogroup", while recent busybox
changed that to "nobody".
Use numeric uids/gids to fix.