shellcheck CI files#2561
Merged
AkihiroSuda merged 3 commits intoopencontainers:masterfrom Aug 20, 2020
Merged
Conversation
AkihiroSuda
reviewed
Aug 19, 2020
AkihiroSuda
reviewed
Aug 19, 2020
Instead of ignoring it, use a throwaway variable _ (yes, just like in Go). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
af95b8b to
0d09d62
Compare
Contributor
Author
|
@AkihiroSuda @mrunalp PTAL |
Commit 335f080 added a test case doing ```bash for i in $(seq 1); do ... done ``` and it does not make any sense to have it since we're only performing a single iteration. Remove the code. I have not touched the indentation, for the sake of cleaner review, also because already have different intentation in different tests; this should be addressed separately. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
0d09d62 to
b8efb02
Compare
mrunalp
approved these changes
Aug 20, 2020
saschagrunert
approved these changes
Aug 20, 2020
AkihiroSuda
requested changes
Aug 20, 2020
AkihiroSuda
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. tests/int/delete.bats: fix shellcheck warnings.
Those are caused by merging #2506 after #2549 without a rebase.
Fixes: #2559
The failures were:
2. tests/int: alt fix for shellcheck SC2034
Instead of ignoring it, use a throwaway variable
_(yes, just like in Go).