Skip to content

CI: shellcheck is failing on master #2559

@AkihiroSuda

Description

@AkihiroSuda

https://travis-ci.org/github/opencontainers/runc/jobs/718839937 (a5847db)

...
shellcheck tests/integration/*.bats
In tests/integration/delete.bats line 64:
  for i in $(seq 1); do
  ^-^ SC2034: i appears unused. Verify use (or export if used externally).
In tests/integration/delete.bats line 65:
    runc run -d --console-socket $CONSOLE_SOCKET test_busybox
                                 ^-------------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean: 
    runc run -d --console-socket "$CONSOLE_SOCKET" test_busybox
In tests/integration/delete.bats line 92:
      eval path=\$${name}/foo
                  ^-----^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean: 
      eval path=\$"${name}"/foo
In tests/integration/delete.bats line 93:
      echo $path
           ^---^ SC2154: path is referenced but not assigned.
           ^---^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean: 
      echo "$path"
In tests/integration/delete.bats line 94:
      [ -d ${path} ] || fail "test failed to create memory sub-cgroup"
           ^-----^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean: 
      [ -d "${path}" ] || fail "test failed to create memory sub-cgroup"
For more information:
  https://www.shellcheck.net/wiki/SC2034 -- i appears unused. Verify use (or ...
  https://www.shellcheck.net/wiki/SC2154 -- path is referenced but not assign...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
Makefile:121: recipe for target 'validate' failed

Seems caused by merging #2506 after #2549 without rebasing.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions