Skip to content

VERSION: release 1.0.0~rc10#2217

Merged
mrunalp merged 2 commits intoopencontainers:masterfrom
cyphar:release-rc10
Jan 27, 2020
Merged

VERSION: release 1.0.0~rc10#2217
mrunalp merged 2 commits intoopencontainers:masterfrom
cyphar:release-rc10

Conversation

@cyphar
Copy link
Member

@cyphar cyphar commented Jan 22, 2020

Signed-off-by: Aleksa Sarai asarai@suse.de

Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
@hqhq
Copy link
Contributor

hqhq commented Jan 23, 2020

LGTM

Approved with PullApprove

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (non binding)

@dims
Copy link
Contributor

dims commented Jan 24, 2020

Yes Please! eagerly waiting for the fix in #2185 (non binding)

@cyphar
Copy link
Member Author

cyphar commented Jan 24, 2020

/ping @opencontainers/runc-maintainers

Since the vote already passed, I've pushed the release tag. It's quite silly that we need two LGTMs for releases, since our review process for releases is so formal...

dims added a commit to dims/containerd that referenced this pull request Jan 24, 2020
We have a new release of runc ( opencontainers/runc#2217 ). This release
has a fix for a race condition we are struggling with in kubernetes
(especially CI jobs) which was fixed in opencontainers/runc#2185

The v1.0.0-rc10 includes the fix for CVE-2019-19921 as well. The full
diff upstream is here:
opencontainers/runc@v1.0.0-rc9...v1.0.0-rc10

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims added a commit to dims/containerd that referenced this pull request Jan 25, 2020
We have a new release of runc ( opencontainers/runc#2217 ). This release
has a fix for a race condition we are struggling with in kubernetes
(especially CI jobs) which was fixed in opencontainers/runc#2185

The v1.0.0-rc10 includes the fix for CVE-2019-19921 as well. The full
diff upstream is here:
opencontainers/runc@v1.0.0-rc9...v1.0.0-rc10

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims added a commit to dims/containerd that referenced this pull request Jan 25, 2020
We have a new release of runc ( opencontainers/runc#2217 ). This release
has a fix for a race condition we are struggling with in kubernetes
(especially CI jobs) which was fixed in opencontainers/runc#2185

The v1.0.0-rc10 includes the fix for CVE-2019-19921 as well. The full
diff upstream is here:
opencontainers/runc@v1.0.0-rc9...v1.0.0-rc10

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
(cherry picked from commit 923c05b)
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims added a commit to dims/containerd that referenced this pull request Jan 25, 2020
We have a new release of runc ( opencontainers/runc#2217 ). This release
has a fix for a race condition we are struggling with in kubernetes
(especially CI jobs) which was fixed in opencontainers/runc#2185

The v1.0.0-rc10 includes the fix for CVE-2019-19921 as well. The full
diff upstream is here:
opencontainers/runc@v1.0.0-rc9...v1.0.0-rc10

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
(cherry picked from commit 923c05b)
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@cyphar
Copy link
Member Author

cyphar commented Jan 25, 2020

@dims For future reference, I would suggest not including a reference to a PR inside a commit message -- GitHub has a (mis)feature where it cross-links commits that reference PRs but this means each time you force push it results in a bunch of annoying spam being included in the history of a PR or issue. Not your fault, it's because GitHub handles this poorly -- but I'd recommend in future that you only reference the PR inside the relevant PR being sent to upstream (GitHub handles that case correctly -- and only provides one cross-reference for the entire PR).

@dims
Copy link
Contributor

dims commented Jan 25, 2020

@cyphar good point. will avoid that. Looks like even when i don't use a full github url in the git commit, github still figures it out and causes spam ( https://github.com/containerd/containerd/commit/0db3c9b78007f1c7fab5d358a95f3dd086258251.patch )

@mrunalp
Copy link
Contributor

mrunalp commented Jan 27, 2020

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit e4c4935 into opencontainers:master Jan 27, 2020
@cyphar cyphar deleted the release-rc10 branch January 28, 2020 04:53
fahedouch pushed a commit to fahedouch/containerd that referenced this pull request Aug 7, 2020
We have a new release of runc ( opencontainers/runc#2217 ). This release
has a fix for a race condition we are struggling with in kubernetes
(especially CI jobs) which was fixed in opencontainers/runc#2185

The v1.0.0-rc10 includes the fix for CVE-2019-19921 as well. The full
diff upstream is here:
opencontainers/runc@v1.0.0-rc9...v1.0.0-rc10

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
tussennet pushed a commit to tussennet/containerd that referenced this pull request Sep 11, 2020
We have a new release of runc ( opencontainers/runc#2217 ). This release
has a fix for a race condition we are struggling with in kubernetes
(especially CI jobs) which was fixed in opencontainers/runc#2185

The v1.0.0-rc10 includes the fix for CVE-2019-19921 as well. The full
diff upstream is here:
opencontainers/runc@v1.0.0-rc9...v1.0.0-rc10

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants