Skip to content

Conversation

@linericyang
Copy link
Contributor

@linericyang linericyang commented Nov 14, 2018

This adds two missing intelRdt parameters in 'runc update' manpage. These two parameters are used to update RDT cache and memory bandwidth config [1].

[1] https://github.com/opencontainers/runc/blob/master/update.go#L117-L124

cc @xiaochenshen

Signed-off-by: Lin Yang <lin.a.yang@intel.com>
@xiaochenshen
Copy link
Contributor

xiaochenshen commented Nov 15, 2018

@linericyang
Thank you for capturing this issue. LGTM.

@crosbymichael
Copy link
Member

crosbymichael commented Nov 16, 2018

LGTM

Approved with PullApprove

@cyphar
Copy link
Member

cyphar commented Nov 18, 2018

LGTM.

Approved with PullApprove

@cyphar cyphar merged commit 4818971 into opencontainers:master Nov 18, 2018
cyphar added a commit that referenced this pull request Nov 18, 2018
  add missing intelRdt parameters in 'runc update' manpage

LGTMs: @crosbymichael @cyphar
Closes #1930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants