Updated logrus to v1#1526
Conversation
|
This replicates the changes done by #1511 but also updates vendor libs too. |
Updated logrus to use v1 which includes a breaking name change Sirupsen -> sirupsen. This includes a manual edit of the docker term package to also correct the name there too. Signed-off-by: Steven Hartland <steven.hartland@multiplay.co.uk>
|
For reference this uses latest commit on 1-0-stable due to missing v1.0.2 tag. |
|
fwiw, i added a new change to #1455 that removes usages of docker/term so we dont have to do manual edit here. |
|
Thanks @dqminh if you prod me when that's merged I'll rebase to remove that part 👍 |
|
@dmcgowan i did a poke on the other PR. I didn't like this too much because it has a manual edit on a dependency. One other way is just to move the docker/pkg dependencies wholesale here (i.e. not import them anymore). we only use 2 small packages there. |
|
@dqminh the circular nature of these imports is pretty obnoxious. I am trying to push forward this change containerd/moby/docker*, wondering if it will be better to vendor logrus twice until everything is updated, I really hate manual vendor edits as well. |
|
LGTM i thought about this abit more and i think it would not be the end of the world if we merge this first before #1455. Since #1455 remove the term package anyway, and we dont update vendor that often (i dont see any pending PR that updates vendor ), i think merging this first has negilibile effect, we just have to be careful when updating vendor, but i hope we can merge #1455 soon 😛 |

Updated logrus to use v1 which includes a breaking name change Sirupsen -> sirupsen.
This includes a manual edit of the docker term package to also correct the name there too.