update to github.com/sirupsen/logrus v1.0.0#1511
Closed
mcandre wants to merge 2 commits intoopencontainers:masterfrom
mcandre:update-logrus
Closed
update to github.com/sirupsen/logrus v1.0.0#1511mcandre wants to merge 2 commits intoopencontainers:masterfrom mcandre:update-logrus
mcandre wants to merge 2 commits intoopencontainers:masterfrom
mcandre:update-logrus
Conversation
added 2 commits
July 6, 2017 17:22
Signed-off-by: Andrew Pennebaker <apennebaker@datapipe.com>
Signed-off-by: Andrew Pennebaker <apennebaker@datapipe.com>
Author
|
Odd, the unit tests are passing in CI, but the Makefile appears to fail the local task anyway. |
Member
|
They're not passing. Here's the highlighted failure. |
Contributor
|
yah, this is because logrus switch the default log output to stderr, while the execintest code only set the buffer to stdout. Change https://github.com/opencontainers/runc/blob/master/libcontainer/integration/execin_test.go#L237 to Stderr should make the test pass. |
Member
|
@mcandre you can revert your last commit to fix the shell changes. If you rebase on master the validation will pass. Sorry for the trouble. |
Contributor
|
@mcandre i can carry this change if you need help for it. Just need a few small fixes i think. |
Merged
Contributor
|
Closed in favor of #1526 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Pennebaker apennebaker@datapipe.com
Fix some dependencies by updating to latest logrus, now hosted at github.com/sirupsen/logrus.